Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8sreporter fails to report target property since provisioningStatus is not set #138

Closed
RemindD opened this issue Feb 18, 2024 · 2 comments · Fixed by #238
Closed

k8sreporter fails to report target property since provisioningStatus is not set #138

RemindD opened this issue Feb 18, 2024 · 2 comments · Fixed by #238
Labels
bug Something isn't working enhancement New feature or request P0

Comments

@RemindD
Copy link
Contributor

RemindD commented Feb 18, 2024

k8sreporter is used to report properties for a target.

However, as the provisioningStatus is marked as a required field in k8s crd, the UpdateStatus call will fail since the provisioningStatus is not set.

    	Error Trace:	symphony/coa/pkg/apis/v1alpha2/providers/reporter/k8s/k8sreporter_test.go:97
    	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"Status", APIVersion:"v1"}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"Status.fabric.symphony \"a1\" is invalid: provisioningStatus: Required value", Reason:"Invalid", Details:(*v1.StatusDetails)(0xc0000dc000), Code:422}}
    	Test:       	TestInitWithMap
@Haishi2016 Haishi2016 added bug Something isn't working enhancement New feature or request P0 labels Feb 28, 2024
@Haishi2016
Copy link
Contributor

Consider to decouple provisioningStatus from Symphony OSS object model. Also consider to split the bug into bug fix to make sure the exception doesn't happen, and splitting object model as enhancement.

@msftcoderdjw
Copy link
Contributor

Assigned to @msftcoderdjw to evaluate if this issue can be resolved after merging codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request P0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants