Cannot create new window after reload the current empty window

[inlann]

Bug Description:

New Window does not work after reload the current window.

BTW, you can open a new window (window 2) before reload it (window 1) and reload the window 2. And then, the menu item New Window of window 2 (that means window 2 is actived) does not work anymore, but the menu item New Window of window 1 (that means window 1 is actived) still works.

Steps to Reproduce:

1. Run the electron example: (We can see the window 1)
   

2. Reload the window: (Reload the window 1)
   
   

3. Click the New Window in the menu but it does not work: (Cannot create a new window)
   

Additional Information

• Operating System: MacOS
• Theia Version: master branch

[kittaakos]

I am also having issues reloading the windows. I have noticed that the electron-main process and the TheiaElectronWindow receives the reload request, but all the isSender calls evaluate as false.

Wouldn't it be better to compare the even.sender.id with this._window.webContents.id here?

theia/packages/core/src/electron-main/theia-electron-window.ts

Lines 183 to 185 in 0f949c2

	protected isSender(e: IpcMainEvent): boolean {
	return BrowserWindow.fromId(e.sender.id) === this._window;
	}

@colin-grant-work, could you please take a look? Thank you!

Related thread: electron/electron#16863 (comment)

---

Update:
Overriding the isSender method like this consistently fixes the issues I am locally having:

diff --git a/arduino-ide-extension/src/electron-main/theia/theia-electron-window.ts b/arduino-ide-extension/src/electron-main/theia/theia-electron-window.ts
index 8c5fd03b..6b2be2cd 100644
--- a/arduino-ide-extension/src/electron-main/theia/theia-electron-window.ts
+++ b/arduino-ide-extension/src/electron-main/theia/theia-electron-window.ts
@@ -64,4 +64,8 @@ export class TheiaElectronWindow extends DefaultTheiaElectronWindow {
       this.toDispose
     );
   }
+
+  protected override isSender(e: IpcMainEvent): boolean {
+    return e.sender.id === this._window.webContents.id;
+  }
 }

[msujew]

@kittaakos Thank you for investigating this. Do you plan on creating a PR on your own? I'll gladly review it.

[kittaakos]

Sure. If this seems to be the proper fix, I am happy to push it back.

[msujew]

It seems pretty reasonable to me. I assume that ids aren't reused by Electron, so comparing between the BrowserWindow instances and the IDs should accomplish the same thing.

[kittaakos]

I will take a look next week. Please assign the task to me.