Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright tests fail in Windows and Mac #12405

Open
planger opened this issue Apr 12, 2023 · 0 comments
Open

Playwright tests fail in Windows and Mac #12405

planger opened this issue Apr 12, 2023 · 0 comments
Labels
playwright issues related to playwright tests

Comments

@planger
Copy link
Contributor

planger commented Apr 12, 2023

https://github.com/marcdumais-work/theia/actions/runs/4679291140

Windows and macOS have failed: Windows has an issue with the way THEIA_CONFIG_DIR is set in playwright package.json. On Mac, there's a failure in theia-text-editor.test.ts, but the new tests have passed. So, I think this PR does not make things worse - if we want to run these tests on the other OS, there will be a bit of work, not directly related to this contribution.

Originally posted by @marcdumais-work in #12381 (comment)


Failure on Windows:

image

Failures on macOS (1/2 passed during retry):

image

image


Here's how to quickly modify the Playwright workflow so it runs on all OS, when pushed on a branch (adjust the branch name, from "playwright-add-terminal", so it matches your test branch):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright issues related to playwright tests
Projects
None yet
Development

No branches or pull requests

1 participant