Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Issues for 1.45.1 #13293

Closed
1 task done
tsmaeder opened this issue Jan 19, 2024 · 14 comments
Closed
1 task done

Backport Issues for 1.45.1 #13293

tsmaeder opened this issue Jan 19, 2024 · 14 comments
Assignees

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jan 19, 2024

Bug Description:

List of issues to backport for the 1.45.1 Community release

@planger
Copy link
Contributor

planger commented Jan 19, 2024

Maybe this one is an easy fix for the next release in order to enable SSH remote development support?
#13294

@tsmaeder
Copy link
Contributor Author

@planger I don't see any changes to be done for that issue. At least no PR is linked in the issue.

@planger
Copy link
Contributor

planger commented Jan 24, 2024

@tsmaeder Yeah, no need for changes immediately, we just need to make sure we also release the native dependencies and upload it to the release.
I was just wondering whether we should automate the publishing of the native dependencies in the release pipeline, otherwise we may forget it in the future again, breaking the remote SSH support.

@tsmaeder
Copy link
Contributor Author

That does not sound like something for a patch release. Also, I am not aware that we need to do anything for the patch release regarding native dependencies, etc. I'm just the piano player.

@tsmaeder
Copy link
Contributor Author

But it does sound like a great issue to open ;-)

@tsmaeder tsmaeder self-assigned this Jan 24, 2024
@planger
Copy link
Contributor

planger commented Jan 24, 2024

That does not sound like something for a patch release. Also, I am not aware that we need to do anything for the patch release regarding native dependencies, etc. I'm just the piano player.

Well, we need to ensure that the release artifacts (also for the patch release) include the native dependency archives, because the URL to download them into the remote machine is constructed from the concrete Theia version (see app-native-dependency-contribution.ts#L39), which is different also between a patch release and the .0 release.
Since there doesn't seem to be an automatic workflow, we need to upload the native dependency archives to the dot release in Github manually, afaik.

But it does sound like a great issue to open ;-)

Definitely, I'll create an issue.

@tsmaeder
Copy link
Contributor Author

Calling @msujew to the rescue.

@msujew
Copy link
Member

msujew commented Jan 24, 2024

We should be able to modify the existing dispatch workflow that generates the artifacts to automatically attach them to each release.

@tsmaeder
Copy link
Contributor Author

But what do we need to do for the 1.45.1 release, @msujew?

@msujew
Copy link
Member

msujew commented Jan 24, 2024

@tsmaeder I've already added the binaries to the release.

@planger
Copy link
Contributor

planger commented Jan 24, 2024

I've added #13308 to track the automation of this step.

@tsmaeder The 1.45.1 release should be fine, because it already contains the native dependency artifacts (probably @msujew added them manually).

@tsmaeder
Copy link
Contributor Author

@msujew could you add steps to https://github.com/eclipse-theia/theia/blob/master/doc/Publishing.md in case we don't have the automation ready for the next release (tomorrow ;-))?

@msujew
Copy link
Member

msujew commented Jan 24, 2024

@tsmaeder I've notified Vince that these files should be added to the release. In the worst case I'm going to add them manually again. It's probably not worth the effort of adding (and then removing) stuff from the documentation.

@tsmaeder
Copy link
Contributor Author

1.45.1 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants