Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3PP license check] Consider switching to dash-licenses - nodejs-wrapper #13426

Open
marcdumais-work opened this issue Feb 27, 2024 · 1 comment
Labels
ci issues related to CI / tests

Comments

@marcdumais-work
Copy link
Contributor

Feature Description:

In this repo, the 3PP license check is performed using a local dash-licenses integration, that's executed as part of CI for PRs (see license-check workflow). This original local integration inspired the creation of a modular wrapper to dash-licenses, that's also more configurable and easy to integrate in new repositories/projects. The new wrapper is available in the form of a npm package: @eclipse-dash/nodejs-wrapper. This tool is developed as part of the Eclipse Foundation technology.dash project, in this repo.

There is arguably no emergency to switch to the new wrapper in this repo, but it could also be desirable to use it to add 3PP license check, as part of PR CI, in other repos in the project, that are not yet covered (e.g. Blueprint repo).

Doing so is not very complicated: see this example of a PR integrating the new modular wrapper, in a new repo that previously did not have 3PP license check.

@marcdumais-work marcdumais-work added the ci issues related to CI / tests label Feb 27, 2024
@marcdumais-work
Copy link
Contributor Author

@JonasHelming FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

No branches or pull requests

1 participant