Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Tab API not working for multiple tab bars #13677

Open
jonah-iden opened this issue May 3, 2024 · 2 comments
Open

VSCode Tab API not working for multiple tab bars #13677

jonah-iden opened this issue May 3, 2024 · 2 comments
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@jonah-iden
Copy link
Contributor

jonah-iden commented May 3, 2024

Bug Description:

It seems like when #12109 was implemented the viewCollumn property was not correctly implemented.
This needs to be retrofitted.
see https://github.com/eclipse-theia/theia/pull/12109/files#diff-cf9def33dbeeb0cd3fa2f7b8026959104e2461870a8c5c8c1dfd7487fad6ac9eR145

Above that there are some more discrepancies.

  • in VSCode the active tabbar is always set
  • there is always at least one tabgroup existing
@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label May 6, 2024
@tsmaeder
Copy link
Contributor

tsmaeder commented May 6, 2024

The fact that TabGroups.activeTabGroup can be undefined causes an Exception at startup in the typescript-language-features 1.88.1 version

@jonah-iden
Copy link
Contributor Author

jonah-iden commented May 6, 2024

@tsmaeder if you find the time could you by any chance test this extension in vscode. Out of some weird reason the tab API seems to be broken there and im only receiving close events in the extension.

Edit: Forget that i just made a really dumb mistake

@jonah-iden jonah-iden self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants