Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileResource causes emitter memory leak #13877

Closed
Hanksha opened this issue Jul 3, 2024 · 2 comments · Fixed by #13880
Closed

FileResource causes emitter memory leak #13877

Hanksha opened this issue Jul 3, 2024 · 2 comments · Fixed by #13880

Comments

@Hanksha
Copy link
Contributor

Hanksha commented Jul 3, 2024

Bug Description:

FileResource class constructor calls fileService.onDidChangeFileSystemProviderReadOnlyMessage but doesn't add it to the toDispose collection which leads to emitter memory leak warnings.

Steps to Reproduce:

  1. Open files more than 175 times
  2. You'll see a emitter memory leak warning in the logs

Additional Information

  • Operating System: Windows, Linux
  • Theia Version: 1.50
@JonasHelming
Copy link
Contributor

Thank you for the report! It seems you have already debugged this, are you interested in a contribution?

@Hanksha
Copy link
Contributor Author

Hanksha commented Jul 3, 2024

@JonasHelming Hi, yes I'll provide a PR.

@Hanksha Hanksha mentioned this issue Jul 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FileResource not adding event listener to the disposable collection Hanksha/theia
2 participants
@JonasHelming @Hanksha