Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] improve error message when LS doesn't start correctly #1481

Closed
marcdumais-work opened this issue Mar 12, 2018 · 2 comments
Closed
Labels
languages issue related to languages typescript issues related to the typescript language

Comments

@marcdumais-work
Copy link
Contributor

It can happen that the TypeScript compiler is missing, when running Theia outside the development environment (e.g. docker images from theia-apps). This causes the TS LS to not start correctly.

The message then given to the user is generic and doesn't help much : "Failed to start language server 'TypeScript'"

We should have a message similar to the one for the C/C++ language client, which is more informative:

https://github.com/theia-ide/theia/blob/e0222f81ddb35a2cdd862f8de81078bfe5b8ce4e/packages/cpp/src/browser/cpp-client-contribution.ts#L41-L58

The error message is customized to give the user useful info about the issue. In this case, we could tell the user to make sure they have the compiler installed: npm install -g typescript

@kittaakos
Copy link
Contributor

@vince-fugnitto vince-fugnitto added typescript issues related to the typescript language languages issue related to languages labels Oct 29, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 5, 2021

Languages packages are gone.

@tsmaeder tsmaeder closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages issue related to languages typescript issues related to the typescript language
Projects
None yet
Development

No branches or pull requests

4 participants