Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to start language server 'JavaScript'. #1566

Closed
jopit opened this issue Mar 21, 2018 · 7 comments
Closed

Failed to start language server 'JavaScript'. #1566

jopit opened this issue Mar 21, 2018 · 7 comments
Labels
typescript issues related to the typescript language

Comments

@jopit
Copy link
Contributor

jopit commented Mar 21, 2018

We're seeing this message when we edit a JavaScript file in our Theia application. Our package.json file does pull in @theia/typescript, which in turn pulls in typescript-language-server, which says it supports both JavaScript and TypeScript.

$ cat package.json 
{
    "private": true,
    "dependencies": {
        "@theia/typescript": "^0.3.7",
        "@theia/navigator": "^0.3.7",
        "@theia/terminal": "^0.3.7",
        "@theia/outline-view": "^0.3.7",
        "@theia/preferences": "^0.3.7",
        "@theia/messages": "^0.3.7",
        "@theia/git": "^0.3.7",
        "@theia/file-search": "^0.3.7",
        "@theia/markers": "^0.3.7",
	"@theia/java": "^0.3.7"
    },
    "devDependencies": {
        "@theia/cli": "^0.3.7"
    }
}

There are no related messages written to the console by the running Theia app. Is there some other dependency that we are missing?

@kittaakos
Copy link
Contributor

kittaakos commented Mar 21, 2018

You could try to install typescript to the global or make it available from the workspace root.
See: #1392 (comment)

@kittaakos
Copy link
Contributor

For some reason, GH does not link the proper comment. I meant this one:

Here is how the language server looks up the tsserver binary:
https://github.com/theia-ide/typescript-language-server/blob/master/src/lsp-server.ts#L69

For sure, we need to send proper information to the user in case it cannot find it. (see typescript-language-server/typescript-language-server#28)

@kittaakos kittaakos added the typescript issues related to the typescript language label Mar 21, 2018
@jopit
Copy link
Contributor Author

jopit commented Mar 22, 2018

OK, installing typescript to the global scope worked, thanks.

Is there a mailing list or blog or someplace where changes like the removal of typescript from the dependencies of typescript-language-server are announced?

Btw, I also noticed that the theia docker image https://hub.docker.com/r/theiaide/theia/ doesn't have typescript installed and so has the same problem.

@marcdumais-work
Copy link
Contributor

@jopit FYI, about the docker images having this issue: theia-ide/theia-apps#29

@kittaakos
Copy link
Contributor

kittaakos commented Mar 22, 2018

Is there a mailing list or blog or someplace where changes like the removal of typescript from the dependencies of typescript-language-server are announced?

I am not aware of such a channel, unfortunately.

Edit: the best is to ask on the Theia Gitter channel.

@akosyakov
Copy link
Member

akosyakov commented Mar 22, 2018

Btw, I also noticed that the theia docker image https://hub.docker.com/r/theiaide/theia/ doesn't have typescript installed and so has the same problem.

thanks for mentioning it, I will check it.

Is there a mailing list or blog or someplace where changes like the removal of typescript from the dependencies of typescript-language-server are announced?

GH notifications :)

@kittaakos
Copy link
Contributor

I am closing this now. @jopit, please reopen, or create a follow-up if you have further questions/problems with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript issues related to the typescript language
Projects
None yet
Development

No branches or pull requests

4 participants