Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] Upgrade electron to version 2.x.x #3728

Closed
thegecko opened this issue Dec 4, 2018 · 0 comments · Fixed by #3779
Closed

[electron] Upgrade electron to version 2.x.x #3728

thegecko opened this issue Dec 4, 2018 · 0 comments · Fixed by #3779
Assignees
@thegecko
Labels
electron issues related to the electron target

Comments

@thegecko
Copy link
Member

thegecko commented Dec 4, 2018 •
edited

In order to take advantage of updates and security fixes in electron, we should upgrade to the latest version of 2.x.x (currently 2.0.14).

This would target the following sub-product versions:

  • Node 8.2.1 > 8.9.3
  • Chrome 59 > 61
  • V8 5.6 > 6.1

We should also update the minimum node version used by Theia to match the above (>=8.2.1).

According to node.green this update wouldn't bring any new ES2015 language features, but does bring others.

ES2015 Array.Values() would still remain unsupported, so should continue to be avoided in Theia.
@thegecko thegecko added the electron issues related to the electron target label Dec 4, 2018
@thegecko thegecko self-assigned this Dec 4, 2018
This was referenced Dec 4, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thegecko thegecko

Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[electron] Upgrade electron to 0.2.14 eclipse-theia/theia
1 participant
@thegecko