Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in] TreeView should be created on registering a TreeDataProvider #3907

Closed
azatsarynnyy opened this issue Dec 28, 2018 · 1 comment
Closed
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility

Comments

@azatsarynnyy
Copy link
Member

Currently, Theia adds a TreeView for each registered TreeDataProvider only once - as soon as the frontend app is reached a ready state. It's not correct behavior for two reasons:

  • a plugin can register a TreeDataProvider at any time but not only from start entrypoint
  • on slow infrastructure a plugin registers TreeDataProvider later than the frontend app goes into a ready state

In any of the cases, plugin's tree isn't shown in a contributed view.

It works perfectly in standalone Theia but the problem is stable reproducible on some slow environment. For example, try the following steps:

When I add some delay before the front app goes into a ready state then tree is shown in the view. To add such delay open several files and reload the browser's page.

@azatsarynnyy azatsarynnyy added plug-in system issues related to the plug-in system bug bugs found in the application labels Dec 28, 2018
@ashumilova ashumilova added the Team: Che-Editors issues regarding the che-editors team label Dec 28, 2018
@vitaliy-guliy vitaliy-guliy self-assigned this Jan 23, 2019
@vitaliy-guliy
Copy link
Contributor

One thing. I suppose TreeView must be created immediately only when ready state of Theia is reached.
Anyway we need to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

6 participants