Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quality] Verify the way we concat FS paths (__dirname + module.js) #4955

Open
2 tasks
kittaakos opened this issue Apr 18, 2019 · 0 comments
Open
2 tasks

[quality] Verify the way we concat FS paths (__dirname + module.js) #4955

kittaakos opened this issue Apr 18, 2019 · 0 comments
Labels
quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

Based on #4954.

Screen Shot 2019-04-18 at 22 46 19

TODO:
@kittaakos kittaakos added the quality issues related to code and application quality label Apr 18, 2019
kittaakos referenced this issue Apr 23, 2019
@kittaakos
Help nexe to locate the TS-LS main module.
e190663 
A module should be required with either a string literal,
or with `path.join(__dirname + stringLiteral)`.
Otherwise, the bundler won't include it in the final executable.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kittaakos