Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug console]selected line get lost after scrolling the window #5969

Open
yeweiasia opened this issue Aug 17, 2019 · 5 comments
Open

[debug console]selected line get lost after scrolling the window #5969

yeweiasia opened this issue Aug 17, 2019 · 5 comments
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help

Comments

@yeweiasia
Copy link
Contributor

yeweiasia commented Aug 17, 2019

Description

If multi line in debug console were selected and scroll the window, selected line will be unselected when they are become invisible. so select long text from debug console become impossible after scrolling.

Reproduction Steps

debug_console_copy_paste

OS and Theia version:
theia 0.9.0
ubuntu 18.04

Diagnostics:

@yeweiasia
Copy link
Contributor Author

this bug also exist in latest version of vscode 1.37.1

@akosyakov akosyakov added bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help labels Aug 17, 2019
@tsmaeder
Copy link
Contributor

The problem here is really that there are two kinds of selection: there is an item selection and there is a text selection. It seem the text selection has no representation in the widget model and thus gets lost when rerendering.
I'm not sure what the right way to go is here: @akosyakov do you have an opinion?

@akosyakov
Copy link
Member

I guess we will need to track it somehow in our react widget. I don't think the react virtualized list supports it. Someone can investigate or ask here: https://github.com/bvaughn/react-virtualized

@tsmaeder
Copy link
Contributor

Does it make sense to have two selections?

@akosyakov
Copy link
Member

I would need to investigate how to handle is the best. An issue seems to be tricky and I could not find a recommended way to handle in the react virtualized community.

I assume that one selects in order to copy. Maybe we could track selected text during scrolling and register a copy event handler for the debug console which copies the tracked text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality help wanted issues meant to be picked up, require help
Projects
None yet
Development

No branches or pull requests

3 participants