Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline API #7577

Closed
dsseng opened this issue Apr 15, 2020 · 9 comments · Fixed by #7997
Closed

Timeline API #7577

dsseng opened this issue Apr 15, 2020 · 9 comments · Fixed by #7997
Assignees
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@dsseng
Copy link
Contributor

dsseng commented Apr 15, 2020

Description

Support Timeline API (beta now).

Reproduction Steps

VS Code Insiders has a proposed API for timelines. this extension can be used for testing .
Maybe this API can only be implemented when VS Code adds it into stable.

OS and Theia version:
Any

Diagnostics:

No

@akosyakov akosyakov added scm issues related to the source control manager vscode issues related to VSCode compatibility labels Apr 15, 2020
@akosyakov
Copy link
Member

We have to implement the widget first in @theia/scm after that connect it with VS Code APIs in @theia/plugin-ext.

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Apr 15, 2020
@dsseng
Copy link
Contributor Author

dsseng commented Apr 16, 2020

@akosyakov it shouldn't be bound to scm, maybe another extension is required.

@akosyakov
Copy link
Member

ok, something like @theia/timeline sounds good as well.

@dsseng
Copy link
Contributor Author

dsseng commented Apr 16, 2020

Great! Not only SCMs can provide timeline data. I think this extension should provide both Theia internal API for extensions to connect to as well as VS Code compliant API for plugins, is this correct? Or only VS Code API will be enough?

@akosyakov
Copy link
Member

akosyakov commented Apr 16, 2020

@theia/timeline should provide API for extensions it is correct, wiring to VS Code API should be done in @theia/plugin-ext. APIs should be aligned though.

@dsseng
Copy link
Contributor Author

dsseng commented Apr 16, 2020

As I've seen from VS Code source, only APIs for Timelines are types and workspace.registerTimelineProvider.

@dsseng
Copy link
Contributor Author

dsseng commented Apr 18, 2020

@akosyakov Looks like existing History View is good for it, maybe with some changes.

@akosyakov
Copy link
Member

@sh7dm Yes, it could be used as the basis. @westbury would it be fine?

@dsseng
Copy link
Contributor Author

dsseng commented Apr 20, 2020

TODO for converting History to Timeline (@ maintainers feel free to update):

  • Add icons support
  • Add VS Code compatible API
    More actions me be required too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants