Searching in files breaks for large workspaces

[csweichel]

Bug Description:

When searching in too large a workspace the search can silently fail. In the logs there's an error message that may be related:

RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length exceeded\n    at Socket.onChildStdout (child_process.js:348:14)\n    at Socket.emit (events.js:189:13)\n    at addChunk (_stream_readable.js:284:12)\n    at readableAddChunk (_stream_readable.js:261:13)\n    at Socket.Readable.push (_stream_readable.js:220:10)\n    at Pipe.onStreamRead (internal/stream_base_commons.js:94:17)

Steps to Reproduce:

1. Open a large workspace
2. Search for a string in all files

Additional Information

• Operating System:
• Theia Version: latest in Gitpod

[akosyakov]

Node.js imposes max buffer constraints on child processes. I've noticed during the fs refactoring that VS Code refactors search to streaming because of this reason. We should do the same to support search in large workspaces.

[FernandoAscencio]

This seems to have been addressed.
Latest commit does not log the error and yields