Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ExtensionMode #10201

Closed
Tracked by #9863
tsmaeder opened this issue Sep 30, 2021 · 1 comment · Fixed by #10977
Closed
Tracked by #9863

Implement ExtensionMode #10201

tsmaeder opened this issue Sep 30, 2021 · 1 comment · Fixed by #10977
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Feature Description:

Add support for the extensionMode field in the ExtensionContext interface. We currently don't support running tests (as far as I know), but we should set "production" and "development" correctly when we run a hosted instance of Theia for a plugin under development.
@tsmaeder tsmaeder added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Sep 30, 2021
@tsmaeder tsmaeder mentioned this issue Sep 30, 2021
Closed
48 tasks
@vince-fugnitto vince-fugnitto mentioned this issue Sep 30, 2021
Merged
1 task
@planger
Copy link
Contributor

planger commented Apr 1, 2022

@eneufeld is looking into this issue.

eneufeld added a commit to eclipsesource/theia that referenced this issue Apr 1, 2022
@eneufeld
Add correct extension mode to plugin context
0747cd5 
The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.

Fix eclipse-theia#10201

Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
@eneufeld eneufeld mentioned this issue Apr 1, 2022
Closed
eneufeld added a commit to eclipsesource/theia that referenced this issue Apr 1, 2022
@eneufeld
Add correct extension mode to plugin context
ad47fcf 
The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.

Fix eclipse-theia#10201

Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
eneufeld added a commit to eclipsesource/theia that referenced this issue Apr 1, 2022
@eneufeld
Add correct extension mode to plugin context
d012b64 
The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.

Fix eclipse-theia#10201

Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
@eneufeld eneufeld mentioned this issue Apr 1, 2022
Merged
1 task
eneufeld added a commit to eclipsesource/theia that referenced this issue May 20, 2022
@eneufeld
Add correct extension mode to plugin context
80c0ab3 
The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.

Fix eclipse-theia#10201

Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
JonasHelming pushed a commit that referenced this issue May 25, 2022
@eneufeld
Add correct extension mode to plugin context (#10977)
1732179 
* Add correct extension mode to plugin context

The plugin context was hardcoded to have the production extensionMode.
Now a flag is passed to mark a plugin as under development when
deploying it. This flag is stored in the plugin metadata and later set in
the plugin. When creating the context this flag is then converted to the
correct extensionMode.

Fix #10201

Contributed on behalf of STMicroelectronics
Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>

* Remove passing `isUnderDevelopment`

As indicated in a review, remove the passing `isUnderDevelopment`
through the deployment system.

* Rebase on master and include review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
2 participants
@planger @tsmaeder