New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
findProtocol SHOULD NOT require base #1270
Comments
At the moment for finding the protocol we check EDIT1: the same goes for |
If not used, we can have it in td-tools repo since playground has its own thing as well at https://github.com/eclipse-thingweb/playground/blob/master/packages/core/index.js#L1293 . It's used to check whether open or async api generation can be done The code in playground looks quite good actually but I had forgotten about it ^^ |
My opinion is as follows:
Question: are we all okay if I provide a PR removing |
We will create a package in td-tools that has such helper functions and then deprecate the functions here. Also, the function in https://github.com/eclipse-thingweb/playground/blob/master/packages/core/index.js#L1293 will be moved there and published. It can be more flexible with some filters like "find it only in properties". td-utils will be the new package name and can contain such tools. It should return an object with binding name as keys (just http, opc etc) then inside it found uri scheme (http, https, mqtt+ws) and subprotocol. |
Originally posted by @egekorkan in eclipse-thingweb/node-red#16 (comment)
The text was updated successfully, but these errors were encountered: