Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): add Node.js 22 to matrix #1274

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danielpeintner
Copy link
Member

fixes #1273

@danielpeintner
Copy link
Member Author

danielpeintner commented Apr 26, 2024

npm ERR! code 1
npm ERR! path /home/runner/work/node-wot/node-wot/node_modules/node-mbus

mbus modbus seems to cause issues on Node.js 22

maybe it fixes Node.js 22 issues
@danielpeintner
Copy link
Member Author

BTW, I created Apollon77/node-mbus#123

@danielpeintner
Copy link
Member Author

I messed up mbus with modbus 🙈

@danielpeintner
Copy link
Member Author

danielpeintner commented Apr 29, 2024

The new error seems to stem from a wrong node installation!?!

https://github.com/eclipse-thingweb/node-wot/actions/runs/8878604576/job/24374716602?pr=1274

@danielpeintner
Copy link
Member Author

danielpeintner commented May 2, 2024

Seems to be related with nodejs/node#52682 and a possible fix can be found here nodejs/node#52682 (comment)

Let's wait a bit. I assume it gets fixed with a new minor version soon.

@relu91
Copy link
Member

relu91 commented May 2, 2024

Should we go with this suggestion ?

@danielpeintner
Copy link
Member Author

Should we go with this suggestion ?

No longer needed since the GH workflow should pick the latest Node.js 22.x version.
Re-running the workflow seems to show that

https://github.com/eclipse-thingweb/node-wot/actions/runs/8878604576/job/24558179052?pr=1274#step:3:91

Anyhow, we are now running into other issues 😒

Now, I think they are really mbus-related.
https://github.com/eclipse-thingweb/node-wot/actions/runs/8878604576/job/24558179052?pr=1274#step:5:25

I will take a closer look next week...

@danielpeintner
Copy link
Member Author

Created Apollon77/node-mbus#124

@danielpeintner
Copy link
Member Author

mbus issue should be resolved (see Apollon77/node-mbus#124 (comment)). We just need to wait till 2.24 is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI - Add Node.js 22 to CI tests
2 participants