Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Naming Business Partner DTO and entity classes #626

Open
martinfkaeser opened this issue Nov 16, 2023 · 1 comment
Open

Refactoring: Naming Business Partner DTO and entity classes #626

martinfkaeser opened this issue Nov 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@martinfkaeser
Copy link
Contributor

martinfkaeser commented Nov 16, 2023 •
edited by nicoprow

Related to #570, we should consistently name our DTOs and entities/embeddables.

I propose the following naming schema:

  • JPA entities and embeddables should be named ..Db.
  • Top-level classes in the API should be called ..Request and ..Response where appropriate.
  • All other API classes shouldn't use the Dto suffix anymore
@martinfkaeser martinfkaeser added the enhancement New feature or request label Nov 16, 2023
@alexsilva-CGI alexsilva-CGI self-assigned this Feb 13, 2024
@alexsilva-CGI alexsilva-CGI mentioned this issue Feb 16, 2024
Closed
2 tasks
@nicoprow
Copy link
Contributor

Updated the top comment clarifying the third point: API model classes should not have DTO as a suffix but rather no suffix at all

This was referenced Feb 28, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
BPDM Kanban
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinfkaeser @nicoprow @alexsilva-CGI