Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QG checks (Release 24.05) #133

Closed
37 tasks done
tomaszbarwicki opened this issue May 10, 2024 · 5 comments
Closed
37 tasks done

QG checks (Release 24.05) #133

tomaszbarwicki opened this issue May 10, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@tomaszbarwicki
Copy link
Contributor

tomaszbarwicki commented May 10, 2024

Quality Gate Checklist

Please keep this issue open until QG is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues, this issue here is for the Overview of the Checks!

Please keep this issue open until QG is concluded!

Product Owner: Ciprian Herciu
Dev SPOC: Aditya Kumar
Helm Chart Version: 1.5.9
App Version: 1.5.6

Release Managemnet Reference Issue:

Check of Tractus-X Release Guidelines

TRG 1 Documentation

  • TRG 1.01 appropriate README.md
  • TRG 1.02 appropriate install instructions either INSTALL.md or in README.md
  • TRG 1.03 appropriate CHANGELOG.md
  • TRG 1.04 editable static files

TRG 2 Git

TRG 3 Kubernetes

  • TRG 3.02 persistent volume and persistent volume claim is used when needed

TRG 4 Container

TRG 5 Helm

  • TRG 5.01 Helm chart requirements
  • TRG 5.02 Helm chart location in /charts directory and correct structure
  • TRG 5.03 proper version strategy
  • TRG 5.04 CPU / MEM resource requests and limits and are properly set
  • TRG 5.06 Application must be configurable through the Helm chart
  • TRG 5.07 Dependencies are present and properly configured in the Chart.yaml
  • TRG 5.08 Product has a single deployable helm chart that contains all components
  • TRG 5.09 Helm Test running properly
  • TRG 5.10 Products need to support 3 versions at a time
  • TRG 5.11 Upgradeability

TRG 6 Released Helm Chart

TRG 7 Open Source Governance

  • TRG 7.01 Legal Documentation
  • TRG 7.02 License and copyright header
  • TRG 7.03 IP checks for project content
  • TRG 7.04 IP checks for 3rd party content
  • TRG 7.05 Legal information for distributions
  • TRG 7.06 Legal information for end user content
  • TRG 7.07 Legal notice for documentation
  • TRG 7.08 Legal notice for KIT documentation

TRG 8 Security

  • TRG 8.01 Mitigate high and above findings in CodeQL
  • TRG 8.02 Mitigate high and above findings in KICS
  • TRG 8.03 Mitigate high and above findings in GitGuardian
  • TRG 8.04 Mitigate high and above findings in Trivy

Hints

Information Sharing

@tomaszbarwicki
Copy link
Contributor Author

Hi @ciprianherciu,

Can you please provide following information?

Product Owner:
Dev SPOC:
Helm Chart Version:
App Version:

@adkumar1
Copy link
Contributor

Product Owner: Ciprian Herciu
Dev SPOC: Aditya Kumar
Helm Chart Version: 1.5.7
App Version: 1.5.4

@tomaszbarwicki
Copy link
Contributor Author

Hi @adkumar1, I was unable to find legal information in the app artifact, can you please take a look into created issue and advise?

Could you also explain how do you implement https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-06 or it's not applicable?

@adkumar1
Copy link
Contributor

Hi @tomaszbarwicki : This has been taken care with PR #151

@almadigabor
Copy link
Contributor

I checked the last remaining issue and trusting @tomaszbarwicki did all the other checks I approve the TRG QG checks with the following versions:

Helm Chart Version: 1.5.9
App Version: 1.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

3 participants