Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(policy): policy seeding data update #88

Merged
merged 7 commits into from
Apr 26, 2024
Merged

feat(policy): policy seeding data update #88

merged 7 commits into from
Apr 26, 2024

Conversation

AnuragNagpure
Copy link
Contributor

Description

Update policy hub seeding data to the latest and greatest policy definition.
GET /api/policy-hub/policy-content
POST /api/policy-hub/policy-content

Why

The policy namespaces (leftOperand and rightOperand values) got recently updated and need to get adjusted for the policy hub.

Issue

#25

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 force-pushed the feature/25-policy-seeding-data-update branch from 51505a8 to cc36f8b Compare April 4, 2024 13:14
@Phil91
Copy link
Member

Phil91 commented Apr 4, 2024

PolicyHub 25.postman_collection.json

Please have a look at the postman collection, I've added requests which results are not as described in the issue:

01 Dismantler
leftOperand: cx-policy:Dismantler.activityType instead of cx-policy:Dismantler
rightOperand: @Dismantler.activityType-Brands instead of active

02 Dismantler with Brand

leftOperand: cx-policy:Dismantler.activityType instead of cx-policy:Dismantler.allowedBrands

03 Framework Credential

rightOperand: should check if that's wanted like that

04 Purpose

rightOperand:

  • missing cx.core
  • which version should be displayed there? currently none is displayed

05 Framework - example traceability

possible values are always starting with active instead with traceability

X (FrameworkAgreement.circulareconomy, FrameworkAgreement.demandcapacity, FrameworkAgreement.puris, FrameworkAgreement.businesspartner)

Dont have a type, useCase and attribute set, which results in a 404

Phil91
Phil91 requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my previous comment

@ntruchsess ntruchsess linked an issue Apr 23, 2024 that may be closed by this pull request
Policy Seeding Data Update 24.05. Scope #25
Open
@AnuragNagpure AnuragNagpure force-pushed the feature/25-policy-seeding-data-update branch from cc36f8b to e0b1498 Compare April 25, 2024 06:47
Phil91
Phil91 requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at Dismantler.allowedBrands and Dismantler from the ticket, this is not yet implemented... before continue working please make sure to pull the latest changes (I've also recreated the migration)

@Phil91 Phil91 force-pushed the feature/25-policy-seeding-data-update branch from d1bb5e0 to 313792d Compare April 25, 2024 16:17
@AnuragNagpure
Copy link
Contributor Author

Please have a look at Dismantler.allowedBrands and Dismantler from the ticket, this is not yet implemented... before continue working please make sure to pull the latest changes (I've also recreated the migration)

Implementation for Dismantler.allowedbrands and Dismantler added

@Phil91 Phil91 merged commit 10bb931 into eclipse-tractusx:dev Apr 26, 2024
9 checks passed
@Phil91 Phil91 deleted the feature/25-policy-seeding-data-update branch April 26, 2024 13:43
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Phil91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy Seeding Data Update 24.05. Scope
2 participants
@AnuragNagpure @Phil91