Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project specific dependencies to latest published stable release #715

Closed
hgo-ds opened this issue Feb 29, 2024 · 9 comments
Closed
Assignees
Labels
backend Backend related issues

Comments

@hgo-ds
Copy link

hgo-ds commented Feb 29, 2024

As TRX Developer,
I want to have project specific dependencies up to date and stable,
so that no SNAPSHOT libraries are in use when trace-x is released.

Hints / Details

  • Third-party libraries, even from project tractus-x should be stable.
    Using SNAPHOT-Releases should be avoided:
    <irs-client-lib.version>1.6.0-SNAPSHOT</irs-client-lib.version>

Acceptance Criteria

  • Project specific dependencies are up to date and stable.

Out of Scope

  • ./.
@ds-lcapellino
Copy link
Contributor

Thanks for raising this issue. We will have an analysis and will come back to you if we have any questions. Please feel free to participate in the open planning for any other concerns.

@hgo-ds
Copy link
Author

hgo-ds commented Mar 1, 2024

Thanks @ds-lcapellino ,
This topic should be added to #658 as well.

@jzbmw jzbmw added the backend Backend related issues label Mar 4, 2024
@mkanal
Copy link
Contributor

mkanal commented Mar 7, 2024

Hey @ds-jhartmann
we should provide a stable library, we should not provide SNAPSHOTS in the future. We release after each iteration, and this release should not depend on SNAPSHOT versions. We should update the maven version with those we are using for GitHub release. Are we able to combine maven and gthub release? Do we need a investigation story for this?

@ds-jhartmann
Copy link
Contributor

Hi @mkanal,
The IRS does not rely on the published maven dependency, since we use the module directly in our code. So from IRS perspective we do not have the need to provide a new release for each IRS release.
During active development we should stay on snapshots and only create a new version once trace-foss needs it.

@hgo-ds
Copy link
Author

hgo-ds commented Mar 7, 2024

Within the IRS, this is probably exactly right.

However, for applications that include the library, such as trace-x, a stable (not SNAPSHOT) version of the IRS client lib should be declared when creating a trace-x release.

Since the trace-x releases are regularly merged into the fork, stable versions of trace-x releases should be used for integrated libraries.

Otherwise, I assume, no deterministic behavior is guaranteed, since the SNAPSHOT version can change at any time.

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Mar 8, 2024

We will adapt our release process to always release the irs-edc-client lib first and use the released version for the Trace-X release. With this, there should be not SNAPSHOT versions in tagged releases anymore. However, we still use SNAPSHOT versions in our main branch.

I'll provide an update as soon as our release process has been adapted.

@ds-lcapellino
Copy link
Contributor

Hi @hgo-ds ,
we've updated our release workflow to not use snapshot versions in tagged releases.
PR: catenax-ng#1051
If you have any further questions, feel free to reopen this issue.

Best
Lucas

@mkanal
Copy link
Contributor

mkanal commented Mar 8, 2024

@ds-jhartmann @hgo-ds @ds-lcapellino
Thank you very much for this valuable exchange.

fyi @jzbmw

@hgo-ds
Copy link
Author

hgo-ds commented Mar 11, 2024

Thanks @ds-lcapellino for providing that solution.

Issue is solved.

Regards
Heinrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues
Projects
Status: done
Development

No branches or pull requests

5 participants