Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete keys from repository #278

Closed
stephanbcbauer opened this issue Apr 25, 2023 · 7 comments · Fixed by #342
Closed

delete keys from repository #278

stephanbcbauer opened this issue Apr 25, 2023 · 7 comments · Fixed by #342
Assignees
Labels
gh-actions refactoring Refactoring, does not add functionality

Comments

@stephanbcbauer
Copy link
Member

Describe the bug

GitGuardien mentioned some issues with our dummy keys in our repository. They are only used for testing purpose and are not valid in the outside world, but there is a need to get rid of them

Expected behavior

The keys should be stored in the repository.

Screenshots/Error Messages

image

Possible Implementation (already discussed in teams)

  • if we just delete them, some of our GH test actions would fail
  • i see two ways forward: a) convince whoever mandated their deletion, that test keys are not really harmful, or b) go Florian Rusch (Guest)'s route an regenerate them every test run. 

b) is cleaner, but more effort

@stephanbcbauer stephanbcbauer added the bug Something isn't working label Apr 25, 2023
@paullatzelsperger paullatzelsperger added refactoring Refactoring, does not add functionality gh-actions labels Apr 26, 2023
@paullatzelsperger
Copy link
Contributor

i don't think this is a bug. nothing is broken, and no functionality is hampered in any way. @stephanbcbauer would you mind moving this to the feature board and removing the bug label?

@bcronin90
Copy link
Contributor

In the past we generated test keys on the fly, so they only ever existed at runtime. Would this be a viable solution here? We basically already have the functionality and could generalize that.

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented May 6, 2023

@bcronin90 yes, that would work fine. It will need to be done for the business tests and the deployment tests.
We would need to include this into the "how-to-run-stuff-locally" documentation, as users would have to generate certs/PKs as well.

@bcronin90
Copy link
Contributor

Thanks for the confirmation. Feel free to assign it to me then.

@bcronin90
Copy link
Contributor

@bcronin90 yes, that would work fine. It will need to be done for the business tests and the deployment tests. We would need to include this into the "how-to-run-stuff-locally" documentation, as users would have to generate certs/PKs as well.

That should all be rather easy to do with bouncycastle. Are we allowed to use that? If so, please feel free to assign the issue to me.

@paullatzelsperger
Copy link
Contributor

@bcronin90 yes, that would work fine. It will need to be done for the business tests and the deployment tests. We would need to include this into the "how-to-run-stuff-locally" documentation, as users would have to generate certs/PKs as well.

That should all be rather easy to do with bouncycastle. Are we allowed to use that? If so, please feel free to assign the issue to me.

I assigned it to you. Regarding BC: what do you have in mind? I was thinking of mostly the command line, as it provides all necessary tools, does not require additional code and is very portable - the openssl program in particular.

@bcronin90 bcronin90 removed their assignment May 10, 2023
@stephanbcbauer
Copy link
Member Author

@bcronin90 , @paullatzelsperger there is currently no assignee. is somebody working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions refactoring Refactoring, does not add functionality
Projects
Status: Done
3 participants