Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not fully ignored in pom.xml. #4069

Closed
ewillink opened this issue Jul 30, 2024 · 3 comments
Closed

Comments are not fully ignored in pom.xml. #4069

ewillink opened this issue Jul 30, 2024 · 3 comments

Comments

@ewillink
Copy link

ewillink commented Jul 30, 2024

The following lines in pom.xml

<!--executionEnvironment>J2SE-1.5</executionEnvironment>
<source-java-version>1.5</source-java-version>
<target-java-version>${source-java-version}</target-java-version-->

caused a build to fail with 1.5 no longer supported. Changing to 1.8 within the comments and everything is ok.

@laeubi
Copy link
Member

laeubi commented Jul 30, 2024

Please share a complete (at best executable) example, this snippet shows nothing that is directly relatable to Tycho and behavior obviously depends on the used version of Tycho and other plugins.

@ewillink
Copy link
Author

It's a simple parser bug. The <!-- ... --> gets confused by the internal < ... > allowing at least the <source-java-version>1.5</source-java-version> to be processed.

@laeubi
Copy link
Member

laeubi commented Jul 30, 2024

The please report this to the maven project, Tycho is not parsing the pom.xml

@laeubi laeubi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants