Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tycho 2.6.0 #490

Closed
24 of 25 tasks
laeubi opened this issue Jan 4, 2022 · 39 comments
Closed
24 of 25 tasks

Release Tycho 2.6.0 #490

laeubi opened this issue Jan 4, 2022 · 39 comments
Assignees
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Jan 4, 2022

Releasing Tycho 2.6.0

This describes the steps to perform a release of Tycho:

  • Make sure all fixed issues and merged PRs have the correct milestone for this release, to finding PRs without milestone you can use the following filter is:pr is:merged no:milestone issues without milestone can be found with is:issue no:milestone is:closed
  • Prepare the release notes which should provide a quick overview of new features and bug fixes
  • Create branch tycho-N.M.x (e.g. tycho-2.4.x) for upcoming release and push it to remote; this branch should remain frozen until the release, only major fixes for regressions could be merged in before release. Work can still happen regularly on the master branch.
  • Create release record on https://projects.eclipse.org/projects/technology.tycho projects.eclipse.org, link the N&N to https://github.com/eclipse/tycho/blob/[branch-name]/RELEASE_NOTES.md release notes]
  • Update the Jenkinsfile on the tycho-N.M.x and adjust the stage('Deploy Snapshot') to reference the new branch in the when conditional.
  • Update versions on master to future release with mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=<NEXT_VERSION>-SNAPSHOT and push to remote
  • Announce the intent to release and request feedback about snapshots on tycho-user@eclipse.org and GitHub discussions:
Subject: Please test snapshots for upcoming <VERSION> release

We plan to release Tycho <VERSION> next week. For details of new features and bugfixes, see release notes [1].
Please help by testing the SNAPSHOTS build. To use it, change your Tycho version to <VERSION>-SNAPSHOT and add snippet [2] to your pom.

We plan to promote this release in one week unless major regressions are found.

Regards,
Tycho team

[1] https://github.com/eclipse/wildwebdeveloper/blob/master/RELEASE_NOTES.md
[2]
<pluginRepositories>
    <pluginRepository>
        <id>tycho-snapshots</id>
        <url>https://repo.eclipse.org/content/repositories/tycho-snapshots/</url>
    </pluginRepository>
</pluginRepositories>

... Wait until review date (usually a week later)...

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd">
   <!-- ... -->
   <servers>
    <server>
      <id>sonatype-nexus-staging</id>
      <username>mickael.istria</username>
      <password>securePassword</password> <!-- use `mvn --encrypt-password` to not store plain text -->
    </server>
    <!-- ... -->
   </servers>
</settings>
</source>
  • git fetch eclipse tycho-N.M.x && git checkout FETCH_HEAD to get the branch to be released
  • Update version to remove -SNAPSHOT with mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=<VERSION>
  • Update versions in tycho-demo folder
  • git add * && git commit version change
  • Sync to release commit and deploy to nexus staging repository: mvn clean deploy -Prelease -DforgeReleaseId=sonatype-nexus-staging -DforgeReleaseUrl=https://oss.sonatype.org/service/local/staging/deploy/maven2/ -DskipTests
  • In the meantime...
    • git tag tycho-<TYCHO_VERSION>
    • Find out who contributed to the release:
git log --pretty=format:%an tycho-<previousVersion>..tycho-<newVersion> | sort | uniq
git log --grep="Also-[bB]y:" tycho-<previousVersion>..tycho-<newVersion> | grep -i also-by | sed -e 's/.*Also-[bB]y:\s*\(.*\)/\1/' | sort | uniq
  • Prepare (in a text editor) announcement, thanking the contributors:
Subject: Tycho <VERSION> is released

Tycho <VERSION> has been released and is available from Maven Central repository.

🆕 https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#xyz
🏷️ https://github.com/eclipse/tycho/tree/tycho-x.y.z
👔 https://projects.eclipse.org/projects/technology.tycho/releases/x.y.z
🙏 contributors who contributed patches for this release:
<contributors>
and thanks and to everyone who helped us with testing the staged version.

Regards,

@laeubi laeubi self-assigned this Jan 4, 2022
@laeubi
Copy link
Member Author

laeubi commented Jan 4, 2022

@mickaelistria @akurtakov I also sceduled a relase review as the release page says:

Reviews are required for all major and minor releases.

should I add this step to the release process documentation?

@laeubi
Copy link
Member Author

laeubi commented Jan 4, 2022

@akurtakov can you create an announcement?

Subject: Tycho 2.6.0 release

We plan to release Tycho 2.6.0 at end of month. For details of new features and bugfixes, see release notes.
Please help by testing the SNAPSHOTS build. To use it, change your tycho version to 2.6.0-SNAPSHOT and add the following snippet to your pom.

<pluginRepositories>
    <pluginRepository>
      <id>tycho-snapshots</id>
      <url>https://repo.eclipse.org/content/repositories/tycho-snapshots/</url>
    </pluginRepository>
</pluginRepositories>

We plan to promote this release at end of month unless major regressions are found that can't be fixed at least one week before the release date.

Regards,
Tycho team

@akurtakov
Copy link
Member

akurtakov commented Jan 4, 2022

Announced intention to release done

@laeubi
Copy link
Member Author

laeubi commented Jan 4, 2022

Great, I have one bug #496 that causes a regression #493, I think we should include the bugfix instead of fixing #493 as this would be a bigger change....

@cdietrich
Copy link
Contributor

Xtext builds seem all fine.

@laeubi
Copy link
Member Author

laeubi commented Jan 10, 2022

@mickaelistria @akurtakov can you take care of https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/169 it seems to require project-lead intervention?

@mickaelistria
Copy link
Contributor

I don't think there is anything to do beyond waiting for review to complete. Did I miss something in particular?

@mickaelistria
Copy link
Contributor

By the way, the release is not necessarily tied to the review now (many things changed recently in EDP). I thinkwethink can just move forward with the release and get review complete in parallel.

@laeubi
Copy link
Member Author

laeubi commented Jan 17, 2022

I don't think there is anything to do beyond waiting for review to complete. Did I miss something in particular?

Yes

By the way, the release is not necessarily tied to the review now (many things changed recently in EDP)

Feel free to stage this as soon as it seems suitable then... 👍

@mickaelistria
Copy link
Contributor

I'd like to make you able to stage/promote release. Can you please perform the steps listed at https://central.sonatype.org/publish/publish-guide/#create-a-ticket-with-sonatype ?

@laeubi
Copy link
Member Author

laeubi commented Jan 17, 2022

What specifically do you wan't me to do? The link seems to point to adding a new project, I assume tycho is already registered? I also have once deployed something to maven-central for another project so probably PGP key should be registered as well.

@mickaelistria
Copy link
Contributor

OK, so if you think you have permission to stage to OSSRH already, please do it. Otherwise, we'll see the error code and ask for more permissions (I don't remember whether OSSRH permissions are per-project or not).

@mickaelistria
Copy link
Contributor

@laeubi Any progress here? Could you push to sonatype OSSRH staging?

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

I get error:

Authorization failed for https://oss.sonatype.org/service/local/staging/deploy/maven2/org/eclipse/tycho/tycho/2.6.0/tycho-2.6.0.pom 403 Forbidden

so it seems I'm not allowed for tycho.

@mickaelistria
Copy link
Contributor

OK, please then open an issue against sonatype ossrh to ask for permissions for Tycho. Add me as CC so I can add a +1 as current maintainer.

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

Artifacts are now deployed to sonartype

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

git log --pretty=format:%an tycho-..tycho- | sort | uniq

git log --pretty=format:%an tycho-2.5.0..tycho-2.6.0 | sort | uniq gives me an error commit or path does not exits...

@mickaelistria
Copy link
Contributor

mickaelistria commented Jan 20, 2022

Does tycho-2.6.0 tag exist on your end?

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

I run

git tag tycho-2.6.0

right before this call as indicated the document.

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

But it seems tycho 2.5.0 tag is missing...

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

strange https://github.com/eclipse/tycho/tags shows the tag by running git-tag locally does not show the tag...

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

I have updated the release doc: ebd1cd9

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

Close the staging repository, get the staging repo URL from Nexus

Should I really close the repository? And what should one do with 'the staging repo URL'

@mickaelistria
Copy link
Contributor

We recently agreed that the staging phase never identified any bug that couldn't be identified earlier on snapshots and decided to ignore the staging phase. So for release, we go directly from staging to release and can ignore the staging URL.

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

We recently agreed that the staging phase never identified any bug that couldn't be identified earlier on snapshots and decided to ignore the staging phase. So for release, we go directly from staging to release and can ignore the staging URL.

I adjusted the docs: 8742450

How long does it takes between closing and the artifacts appear on central?

@mickaelistria
Copy link
Contributor

In my experience, between 5 and 10 minutes.

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

It seems I can't access ssh://<user_id>@git.eclipse.org:29418/www.eclipse.org/tycho.git do I need special permissions?

@cdietrich
Copy link
Contributor

dont you need to close AND release?

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

dont you need to close AND release?

No idea :-) Close was the only available action and the documentation indicates so...

@cdietrich
Copy link
Contributor

in xtext we hit close. then refresh button. then release

@laeubi
Copy link
Member Author

laeubi commented Jan 20, 2022

in xtext we hit close. then refresh button. then release

After refresh it show No staging repositories available

@cdietrich
Copy link
Contributor

cdietrich commented Jan 20, 2022

https://central.sonatype.org/publish/release/ also says close and release
maybe closing takes some time ...

@cdietrich
Copy link
Contributor

wonder if you really closed it
i can see this one
Bildschirmfoto 2022-01-20 um 19 42 38

@cdietrich
Copy link
Contributor

cdietrich commented Jan 21, 2022

looks like the repo still did not appear in central. can you check once more if your list is really empty?

@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

I can now see the repo again, but it has failures, one seems to be related to

and it seems I used the wrong pgp key (will check that)

grafik

@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

I have updated the docs regarding the checks and how to perform the release of the staging repository: 5c83ecd

@laeubi laeubi removed their assignment Jan 21, 2022
@laeubi
Copy link
Member Author

laeubi commented Jan 21, 2022

Release is done for this now, I think we can omit advertising at tycho-dev@eclipse.org and for the twitter stuff I left this to someone else if desired (I dont use twitter at all ...).

@laeubi laeubi closed this as completed Jan 21, 2022
@akurtakov
Copy link
Member

Announcement on tycho-dev is required as this is the "official" channel for Eclipse Foundation projects.

@laeubi laeubi added this to the 2.7 milestone Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants