Skip to content

Commit

Permalink
Minor rename getSni -> isSni option
Browse files Browse the repository at this point in the history
  • Loading branch information
vietj committed Apr 24, 2017
1 parent 691f31e commit 06c4d2e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Expand Up @@ -57,6 +57,6 @@ public static void toJson(NetServerOptions obj, JsonObject json) {
json.put("host", obj.getHost()); json.put("host", obj.getHost());
} }
json.put("port", obj.getPort()); json.put("port", obj.getPort());
json.put("sni", obj.getSni()); json.put("sni", obj.isSni());
} }
} }
2 changes: 1 addition & 1 deletion src/main/java/io/vertx/core/http/impl/HttpServerImpl.java
Expand Up @@ -265,7 +265,7 @@ protected void initChannel(Channel ch) throws Exception {
} }
ChannelPipeline pipeline = ch.pipeline(); ChannelPipeline pipeline = ch.pipeline();
if (sslHelper.isSSL()) { if (sslHelper.isSSL()) {
if (options.getSni()) { if (options.isSni()) {
VertxSniHandler sniHandler = new VertxSniHandler(sslHelper, vertx); VertxSniHandler sniHandler = new VertxSniHandler(sslHelper, vertx);
pipeline.addLast(sniHandler); pipeline.addLast(sniHandler);
postSSLConfig(pipeline); postSSLConfig(pipeline);
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/vertx/core/net/NetServerOptions.java
Expand Up @@ -81,7 +81,7 @@ public NetServerOptions(NetServerOptions other) {
this.host = other.getHost(); this.host = other.getHost();
this.acceptBacklog = other.getAcceptBacklog(); this.acceptBacklog = other.getAcceptBacklog();
this.clientAuth = other.getClientAuth(); this.clientAuth = other.getClientAuth();
this.sni = other.getSni(); this.sni = other.isSni();
} }


/** /**
Expand Down Expand Up @@ -359,7 +359,7 @@ public NetServerOptions setLogActivity(boolean logEnabled) {
* *
* @return true if the server supports Server Name Indication * @return true if the server supports Server Name Indication
*/ */
public boolean getSni() { public boolean isSni() {
return sni; return sni;
} }


Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/vertx/core/net/impl/NetServerBase.java
Expand Up @@ -327,7 +327,7 @@ public void channelActive(ChannelHandlerContext ctx) throws Exception {


if (sslHelper.isSSL()) { if (sslHelper.isSSL()) {
io.netty.util.concurrent.Future<Channel> handshakeFuture; io.netty.util.concurrent.Future<Channel> handshakeFuture;
if (options.getSni()) { if (options.isSni()) {
VertxSniHandler sniHandler = new VertxSniHandler(sslHelper, vertx); VertxSniHandler sniHandler = new VertxSniHandler(sslHelper, vertx);
handshakeFuture = sniHandler.handshakeFuture(); handshakeFuture = sniHandler.handshakeFuture();
ch.pipeline().addFirst("ssl", sniHandler); ch.pipeline().addFirst("ssl", sniHandler);
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/vertx/core/net/impl/SSLHelper.java
Expand Up @@ -179,7 +179,7 @@ public SSLHelper(HttpServerOptions options, KeyCertOptions keyCertOptions, Trust
this.useAlpn = options.isUseAlpn(); this.useAlpn = options.isUseAlpn();
this.enabledProtocols = options.getEnabledSecureTransportProtocols(); this.enabledProtocols = options.getEnabledSecureTransportProtocols();
this.openSslSessionCacheEnabled = (sslEngineOptions instanceof OpenSSLEngineOptions) && ((OpenSSLEngineOptions) sslEngineOptions).isSessionCacheEnabled(); this.openSslSessionCacheEnabled = (sslEngineOptions instanceof OpenSSLEngineOptions) && ((OpenSSLEngineOptions) sslEngineOptions).isSessionCacheEnabled();
this.sni = options.getSni(); this.sni = options.isSni();
} }


public SSLHelper(NetClientOptions options, KeyCertOptions keyCertOptions, TrustOptions trustOptions) { public SSLHelper(NetClientOptions options, KeyCertOptions keyCertOptions, TrustOptions trustOptions) {
Expand Down Expand Up @@ -213,7 +213,7 @@ public SSLHelper(NetServerOptions options, KeyCertOptions keyCertOptions, TrustO
this.useAlpn = false; this.useAlpn = false;
this.enabledProtocols = options.getEnabledSecureTransportProtocols(); this.enabledProtocols = options.getEnabledSecureTransportProtocols();
this.openSslSessionCacheEnabled = (options.getSslEngineOptions() instanceof OpenSSLEngineOptions) && ((OpenSSLEngineOptions) options.getSslEngineOptions()).isSessionCacheEnabled(); this.openSslSessionCacheEnabled = (options.getSslEngineOptions() instanceof OpenSSLEngineOptions) && ((OpenSSLEngineOptions) options.getSslEngineOptions()).isSessionCacheEnabled();
this.sni = options.getSni(); this.sni = options.isSni();
} }


public boolean isSSL() { public boolean isSSL() {
Expand Down

0 comments on commit 06c4d2e

Please sign in to comment.