HttpServerFileUpload should be resumed when the pending inbound buffe…

…r is drained - fixes #2736
eclipse-vertx · Nov 28, 2018 · cdc8172 · cdc8172
1 parent b9a934e
commit cdc8172
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java b/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java
@@ -63,6 +63,7 @@ class HttpServerFileUploadImpl implements HttpServerFileUpload {
     this.charset = charset;
     this.size = size;
     this.pending = new InboundBuffer<Buffer>(context)
+      .drainHandler(v -> req.resume())
       .emptyHandler(v -> {
         if (complete) {
           handleComplete();

diff --git a/src/test/java/io/vertx/core/http/HttpTest.java b/src/test/java/io/vertx/core/http/HttpTest.java
@@ -2733,18 +2733,28 @@ public void testFormUploadSmallFile() throws Exception {
   }
 
   @Test
-  public void testFormUploadLargerFile() throws Exception {
+  public void testFormUploadMediumFile() throws Exception {
     testFormUploadFile(TestUtils.randomAlphaString(20000), false);
   }
 
+  @Test
+  public void testFormUploadLargeFile() throws Exception {
+    testFormUploadFile(TestUtils.randomAlphaString(4 * 1024 * 1024), false);
+  }
+
   @Test
   public void testFormUploadSmallFileStreamToDisk() throws Exception {
     testFormUploadFile(TestUtils.randomAlphaString(100), true);
   }
 
   @Test
-  public void testFormUploadLargerFileStreamToDisk() throws Exception {
+  public void testFormUploadMediumFileStreamToDisk() throws Exception {
-    testFormUploadFile(TestUtils.randomAlphaString(20000), true);
+    testFormUploadFile(TestUtils.randomAlphaString(20 * 1024), true);
+  }
+
+  @Test
+  public void testFormUploadLargeFileStreamToDisk() throws Exception {
+    testFormUploadFile(TestUtils.randomAlphaString(4 * 1024 * 1024), true);
   }
 
   private void testFormUploadFile(String contentStr, boolean streamToDisk) throws Exception {