Context#executeBlocking does not log blocked threads - fixes #1633

eclipse-vertx · Sep 21, 2016 · e4eb213 · e4eb213
1 parent 9736108
commit e4eb213
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/src/main/java/io/vertx/core/impl/ContextImpl.java b/src/main/java/io/vertx/core/impl/ContextImpl.java
@@ -248,10 +248,14 @@ <T> void executeBlocking(Action<T> action, Handler<Future<T>> blockingCodeHandle
     Object queueMetric = metrics != null ? metrics.submitted() : null;
     try {
       exec.execute(() -> {
+        VertxThread current = (VertxThread) Thread.currentThread();
         Object execMetric = null;
         if (metrics != null) {
           execMetric = metrics.begin(queueMetric);
         }
+        if (!DISABLE_TIMINGS) {
+          current.executeStart();
+        }
         Future<T> res = Future.future();
         try {
           if (blockingCodeHandler != null) {
@@ -263,6 +267,10 @@ <T> void executeBlocking(Action<T> action, Handler<Future<T>> blockingCodeHandle
           }
         } catch (Throwable e) {
           res.fail(e);
+        } finally {
+          if (!DISABLE_TIMINGS) {
+            current.executeEnd();
+          }
         }
         if (metrics != null) {
           metrics.end(execMetric, res.succeeded());

diff --git a/src/test/java/io/vertx/test/core/BlockedThreadCheckerTest.java b/src/test/java/io/vertx/test/core/BlockedThreadCheckerTest.java
@@ -61,9 +61,33 @@ public void start() throws InterruptedException {
     vertxOptions.setMaxWorkerExecuteTime(1000000000);
     vertxOptions.setWarningExceptionTime(1000000000);
     Vertx newVertx = vertx(vertxOptions);
-    DeploymentOptions depolymentOptions = new DeploymentOptions();
+    DeploymentOptions deploymentOptions = new DeploymentOptions();
-    depolymentOptions.setWorker(true);
+    deploymentOptions.setWorker(true);
-    newVertx.deployVerticle(verticle, depolymentOptions);
+    newVertx.deployVerticle(verticle, deploymentOptions);
+    await();
+  }
+
+  @Test
+  public void testBlockCheckExecuteBlocking() throws Exception {
+    Verticle verticle = new AbstractVerticle() {
+      @Override
+      public void start() throws InterruptedException {
+        vertx.executeBlocking(fut -> {
+          try {
+            Thread.sleep(2000);
+          } catch (InterruptedException e) {
+            fail();
+          }
+          testComplete();
+        }, ar -> {});
+      }
+    };
+    // set warning threshold to 1s and the exception threshold as well
+    VertxOptions vertxOptions = new VertxOptions();
+    vertxOptions.setMaxWorkerExecuteTime(1000000000);
+    vertxOptions.setWarningExceptionTime(1000000000);
+    Vertx newVertx = vertx(vertxOptions);
+    newVertx.deployVerticle(verticle);
     await();
   }
 }