Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Message Producer #1382

Closed
amannocci opened this issue Apr 17, 2016 · 4 comments
Closed

Fix Message Producer #1382

amannocci opened this issue Apr 17, 2016 · 4 comments

Comments

@amannocci
Copy link
Contributor

Motivation:
We forget to add credit header in MessageProducer when we set it with deliveryOptions.
As a result the drain handler will never be call.

Modification:
Add credit header when we set delivery options.

Result:
The drain handler will be call in every situation.

@vietj
Copy link
Member

vietj commented Apr 23, 2016

Hi, can you contribute a test + implementation ?

@amannocci
Copy link
Contributor Author

Tell me what you think about this little fix

@vietj
Copy link
Member

vietj commented May 23, 2016

looks good to me, however we should make a copy of the options because the same options may be used in two producers leading to problems.

can you add this ? then it will be good for a PR.

@amannocci
Copy link
Contributor Author

Fixed #1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants