New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a method in HttpClientReuqest to get the request metric #4023
Comments
In vert.x 3.x, we get request begin & end by
But can not find a way in 4.x. Our usage is wrong in 3.x. And we find 4.x fixed this but can not get request metric. |
Indeed in Vert.x 4 the metric object is held by @vietj what do you think about exposing the metric object in public Object metric() {
return stream.metric();
} |
what is the actual use case that is intended ? |
Get request metric can know request begin, request end, resonse begin and response end time, this is usefully for performance issues. We need reporting time token between request send and response received and need access request metric to do this. |
code snippet
|
Describe the feature
We are reporting metrics using VertxMetrics, and get metric object through
HttpClientRequest.connection().metric()
.This is fine to get TCPMetrics.
Request metric is accessable in HttpClientStream, but it is a protected member of HttpClientRequest, and we can not get the request metrics.
Use cases
Report request metrics like time taken in request begin and end.
Contribution
I am not sure if it is suitable to add a method
Object metric()
in HttpClientRequest, and I can create a PR if it is fine.The text was updated successfully, but these errors were encountered: