Empty Host header not supported anymore

[cescoffier]

Describe the bug

Empty host header not supported anymore

curl -iv -H "User-Agent:" -H "Accept:" -H "Host:" http://localhost:8080/foo

Fails with 500 and an NullPointerException in log.

[vietj]

FTR: correct curl line is curl -iv -H "User-Agent;" -H "Accept;" -H "Host;" http://localhost:8080/foo

[vietj]

I tried with latest Vert.x 4.4 branch and 4.x branch with an hello-world HTTP server and it does not happen, can you provide more details ? like the exception or maybe I am missing vertx-web handlers that create this NPE (although this is reported on vertx-core)

[cescoffier]

So, it seems to be in Vert.x Web.

The NPE is in HostAndPortImpl:

  public HostAndPortImpl(String host, int port) {
    if (host == null) {
      throw new NullPointerException(); // Thrown...
    }
    this.host = host;
    this.port = port;
  }

that line got called from the ForardedPArser of Vert.x Web ( authority = HostAndPort.create(host, port); line 137 )

[cescoffier]

@vietj

Here is the all in one reproducer:

///usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS io.vertx:vertx-web:4.4.5

import io.vertx.core.Vertx;
import io.vertx.ext.web.Router;
import static java.lang.System.*;

public class VertxHostNpe {

    public static void main(String... args) throws Exception {
    
            Vertx vertx = Vertx.vertx();
            Router router = Router.router(vertx);
            router.get("/").handler(ctx -> {
                ctx.response().end("Hello World! " + ctx.request().host());
            });


            vertx.createHttpServer()
                .requestHandler(router)
                .listen(8080);

            Thread.sleep(100000);    

    }
}

Run it with:

jbang "/Users/clement/Downloads/VertxHostNpe.java"

and in another terminal: curl -iv -H "User-Agent:" -H "Accept:" -H "Host;" http://localhost:8080

You will get the NPE I mentioned above:

java.lang.NullPointerException
        at io.vertx.core.net.impl.HostAndPortImpl.<init>(HostAndPortImpl.java:144)
        at io.vertx.core.net.HostAndPort.create(HostAndPort.java:20)
        at io.vertx.ext.web.impl.ForwardedParser.calculate(ForwardedParser.java:137)
        at io.vertx.ext.web.impl.ForwardedParser.host(ForwardedParser.java:76)
        at io.vertx.ext.web.impl.HttpServerRequestWrapper.host(HttpServerRequestWrapper.java:183)
        at VertxHostNpe.lambda$main$0(VertxHostNpe.java:15)

[vietj]

thanks, was missing that