Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Improve parsing dates and times #57

Closed
lucaspouzac opened this issue Jan 25, 2024 · 3 comments · Fixed by #58
Closed

[Performance] Improve parsing dates and times #57

lucaspouzac opened this issue Jan 25, 2024 · 3 comments · Fixed by #58
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lucaspouzac
Copy link
Contributor

lucaspouzac commented Jan 25, 2024

Actually, io.vertx.httpproxy.impl.ParseUtils use SimpleDateFormat to parse a date.

It would certainly be possible to improve memory consumption, perhaps using another more efficient method (LocalDateTime.parse ?)

Java Flight Recorder during 300s
I observe more than 4% of the memory consumption of my application linked to this analysis.

Screenshot showing 1,3% of memory usage.
image

Observed with the version 4.5.1 (from quarkus 3.7.0)

@lucaspouzac lucaspouzac added the bug Something isn't working label Jan 25, 2024
@vietj
Copy link
Member

vietj commented Jan 25, 2024

do you mind contributing a patch @lucaspouzac ?

@lucaspouzac
Copy link
Contributor Author

Ok, next thursday.

@tsegismont tsegismont self-assigned this Jan 29, 2024
@tsegismont tsegismont added this to the 4.5.2 milestone Jan 29, 2024
@tsegismont tsegismont changed the title [Performance] Improve parsing data [Performance] Improve parsing dates and times Jan 29, 2024
@tsegismont
Copy link
Contributor

Fixed by 324efed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants