You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently query or update in PgOperations use List<Object> to hold multiple params, API is something like this void query(String sql, List<Object> params, Handler<AsyncResult<ResultSet>> handler);
or void update(String sql, List<Object> params, Handler<AsyncResult<UpdateResult>> handler);
Motivation
As it's defined in vertx-sql-common, SQLOperations use JsonArray to hold mutiple params like SQLOperations queryWithParams(String sql, JsonArray params, Handler<AsyncResult<ResultSet>> resultHandler);
or SQLOperations updateWithParams(String sql, JsonArray params, Handler<AsyncResult<UpdateResult>> resultHandler);
It's better to keep consistency, is it right?
Apart from this, List<Object> is also not supported by Codegen when passing as input parameters, so the method has to be ignored by @GenIgnore. When using Rxi-fied API, there is no methods to take multiple params as one collection, users have to maintain a state of how many params they use and then choose which method to use, this is not convenient when facing dynamic SQLs.
Therefore is there any possibility to change this?
The text was updated successfully, but these errors were encountered:
Status
Currently query or update in PgOperations use
List<Object>
to hold multiple params, API is something like thisvoid query(String sql, List<Object> params, Handler<AsyncResult<ResultSet>> handler);
or
void update(String sql, List<Object> params, Handler<AsyncResult<UpdateResult>> handler);
Motivation
As it's defined in vertx-sql-common, SQLOperations use
JsonArray
to hold mutiple params likeSQLOperations queryWithParams(String sql, JsonArray params, Handler<AsyncResult<ResultSet>> resultHandler);
or
SQLOperations updateWithParams(String sql, JsonArray params, Handler<AsyncResult<UpdateResult>> resultHandler);
It's better to keep consistency, is it right?
Apart from this,
List<Object>
is also not supported by Codegen when passing as input parameters, so the method has to be ignored by@GenIgnore
. When using Rxi-fied API, there is no methods to take multiple params as one collection, users have to maintain a state of how many params they use and then choose which method to use, this is not convenient when facing dynamic SQLs.Therefore is there any possibility to change this?
The text was updated successfully, but these errors were encountered: