default the port number

[gavinking]

Currently it's necessary to explicitly specify port numbers with ConnectOptions, but every database has a default port, so the default port should be implied.

[vietj]

if you use SqlConnectOptions subclasses then you get the right port by default.

This class used to be abstract and user have to create the right subclass in order to get the proper default. A recent PR changed that and now we get this wrong default.

There is currently a discussion to add a "database product name" to SqlConnectOptions.

[gavinking]

Oh OK, so should I just close this issue then?

[vietj]

I think we keep it open for now

[gavinking]

@vietj is this issue still relevant?

[vietj]

I think it cannot be resolved so we can close it. Other ways to create options should be used.