Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ViatraQueryTest builder the actual and expected values can be accidentally mixed up #134

Open
eclipse-viatra-bot opened this issue Mar 12, 2024 · 0 comments
Labels
Addons bugzilla Issues migrated from Eclipse bugzilla.

Comments

@eclipse-viatra-bot
Copy link

| --- | --- |
| Bugzilla Link | 578240 |
| Status | UNCONFIRMED |
| Importance | P3 normal |
| Reported | Jan 17, 2022 05:14 EDT |
| Modified | Jan 17, 2022 05:14 EDT |
| Reporter | Benedek Horvath |

Description

At the moment, in the ViatraQueryTest builder the with method sets both the actual and the expected result, depending on the order in which it is called. The first call of the with sets the actual result and the second call set the expected result.

From the API user's perspective it would be better if there were different method for setting the actual and the expected results, e.g. withExpected, withActual, to avoid confusion.

@eclipse-viatra-bot eclipse-viatra-bot added Addons bugzilla Issues migrated from Eclipse bugzilla. legacy labels Mar 12, 2024
@ujhelyiz ujhelyiz removed the legacy label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addons bugzilla Issues migrated from Eclipse bugzilla.
Projects
None yet
Development

No branches or pull requests

2 participants