Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent_version RPC call #189

Open
riley206 opened this issue Mar 14, 2024 · 5 comments
Open

agent_version RPC call #189

riley206 opened this issue Mar 14, 2024 · 5 comments

Comments

@riley206
Copy link

riley206 commented Mar 14, 2024

Describe the bug
agent_version RPC does not get versions.

run the agent_version rpc call with a UUID.

Expected behavior
We expect it to return the agent_version. Instead pkg.version is hardcoded.

def agent_version(self, agent_uuid):
    if "/" in agent_uuid or agent_uuid in [".", ".."]:
        raise ValueError("invalid agent")
    agent_path = os.path.join(self.install_dir, agent_uuid)
    name = self.agent_name(agent_uuid)
    pkg = None
    pkg.version = "4.4"
    # TODO: wheel_wrap
    # pkg = UnpackedPackage(os.path.join(agent_path, name))
    return pkg.version

def agent_version(self, agent_uuid):
)

@craig8
Copy link
Contributor

craig8 commented Mar 15, 2024

Perhaps you could provide a link to the copied function so we can click on it. This does sound like an issue however.

@riley206
Copy link
Author

Perhaps you could provide a link to the copied function so we can click on it. This does sound like an issue however.

My fault, I have added the link.

@craig8
Copy link
Contributor

craig8 commented Mar 15, 2024

Perhaps you could provide a link to the copied function so we can click on it. This does sound like an issue however.

My fault, I have added the link.

Where did you provide that link from? In general, I think it's better to provide from upstream...

def agent_version(self, agent_uuid):

@riley206
Copy link
Author

Perhaps you could provide a link to the copied function so we can click on it. This does sound like an issue however.

My fault, I have added the link.

Where did you provide that link from? In general, I think it's better to provide from upstream...

def agent_version(self, agent_uuid):

I got it from main. Which is what I was using when I found the issue.

@craig8
Copy link
Contributor

craig8 commented Mar 15, 2024

Perhaps you could provide a link to the copied function so we can click on it. This does sound like an issue however.

My fault, I have added the link.

Where did you provide that link from? In general, I think it's better to provide from upstream...

def agent_version(self, agent_uuid):

I got it from main. Which is what I was using when I found the issue.

Ahh...you should be debugging with develop in general. That's where the pip install --pre will be from. Anyways the codes the same in both so this is an issue either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants