Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistency in Output and Input types function names. #122

Closed
gabrik opened this issue Sep 26, 2022 · 1 comment
Closed

[Bug] Inconsistency in Output and Input types function names. #122

gabrik opened this issue Sep 26, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gabrik
Copy link
Contributor

gabrik commented Sep 26, 2022

Describe the bug

There is an inconsistency in the Output and Input types in the name of the function used to retrieve the ID.

In Input we have:

impl Input {
    pub fn id(&self) -> &PortId {
        &self.id
    }
    ...
}

While in Output we have:

impl Output {
    /// Returns the port id associated with this Output.
    ///
    /// Port ids are unique per type (i.e. Input / Output) and per node.
    pub fn port_id(&self) -> &PortId {
        &self.port_id
    }
    ...
 }   

They should be the same, so either id() or port_id()

To reproduce

N/A

System info

N/A

@gabrik
Copy link
Contributor Author

gabrik commented Oct 31, 2022

Fixed in: ZettaScaleLabs#6

@J-Loudet J-Loudet closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants