Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_reception_timestamp() should be method of session #1068

Closed
milyin opened this issue May 30, 2024 · 1 comment · Fixed by #1091
Closed

new_reception_timestamp() should be method of session #1068

milyin opened this issue May 30, 2024 · 1 comment · Fixed by #1091
Assignees
Labels
api fix Correct API release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented May 30, 2024

Describe the release item

new_reception_timestamp() is somehow weird since ZenohId is always set to 1. To be verified wether should become a method of the session and be called new_timestamp().

@milyin milyin added release Part of the next release api fix Correct API labels May 30, 2024
@milyin
Copy link
Contributor Author

milyin commented Jun 5, 2024

it's inconvenient to put it into session. All what is needed from session is session's id. This will require store pointer to session, although the copy of session id would be enough. This is the case for Snapshotter structure: https://github.com/eclipse-zenoh/zenoh/blob/main/plugins/zenoh-plugin-storage-manager/src/replica/snapshotter.rs#L28

@milyin milyin self-assigned this Jun 5, 2024
@milyin milyin linked a pull request Jun 5, 2024 that will close this issue
@milyin milyin closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fix Correct API release Part of the next release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant