Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSlice and ZBytes are internal now. Can we avoid their usage in shm examples #1081

Closed
milyin opened this issue Jun 3, 2024 · 3 comments
Closed

ZSlice and ZBytes are internal now. Can we avoid their usage in shm examples #1081

milyin opened this issue Jun 3, 2024 · 3 comments
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Jun 3, 2024 •
edited
Loading

Describe the release item

It was decided to move ZSlice and ZBuf into internal mod. But these structs are used in shm examples.
Should we fix examples or the decision to make these things internal doesn't work for shm?
@yellowhatter can you check?
@milyin milyin added the release Part of the next release label Jun 3, 2024
@wyfo
Copy link

wyfo commented Jun 4, 2024

I think you wrote ZBbytes instead ZBuf. ZBytes is meant to be public, it appears everywhere in the API. ZBuf is the internal implementation of ZBytes.

@milyin milyin mentioned this issue Jun 6, 2024
Merged
@Mallets
Copy link
Member

Mallets commented Jun 12, 2024

@yellowhatter can you please take care of it?

@yellowhatter yellowhatter mentioned this issue Jun 13, 2024
Merged
@yellowhatter
Copy link
Contributor

@milyin examples fixed: #1129

@Mallets Mallets closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@milyin @Mallets @wyfo @yellowhatter