BIRT 1388: Incorrect wording in context menu to create a new master page

Signed-off-by: Shijie Zhang <szhang@opentext.com>
eclipse-birt · Nov 18, 2015 · 7077fc3 · 7077fc3
1 parent 3de3603
commit 7077fc3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/...se.birt.report.designer.core/src/org/eclipse/birt/report/designer/nls/messages.properties b/...se.birt.report.designer.core/src/org/eclipse/birt/report/designer/nls/messages.properties
@@ -2287,6 +2287,7 @@ InputParameterDialog.boolean.checked=Yes
 #InsertAction properties
 
 InsertAction.text=I&nsert Element
+NewMasterPage.text=&New master page
 
 ###########################################################
 #InsertColumnAction properties

diff --git a/...igner.ui/src/org/eclipse/birt/report/designer/internal/ui/views/actions/InsertAction.java b/...igner.ui/src/org/eclipse/birt/report/designer/internal/ui/views/actions/InsertAction.java
@@ -27,7 +27,9 @@
 import org.eclipse.birt.report.model.api.ListingHandle;
 import org.eclipse.birt.report.model.api.PropertyHandle;
 import org.eclipse.birt.report.model.api.SlotHandle;
+import org.eclipse.birt.report.model.api.core.IModuleModel;
 import org.eclipse.birt.report.model.api.elements.ReportDesignConstants;
+import org.eclipse.birt.report.model.api.ReportDesignHandle;
 import org.eclipse.birt.report.model.elements.interfaces.IListingElementModel;
 import org.eclipse.gef.Request;
 
@@ -46,7 +48,9 @@ public class InsertAction extends AbstractElementAction
 
 	public final static String CURRENT = "current"; //$NON-NLS-1$
 
-	private final static String TEXT = Messages.getString( "InsertAction.text" ); //$NON-NLS-1$
+	private final static String INSERT_TEXT = Messages.getString( "InsertAction.text" ); //$NON-NLS-1$
+
+	private final static String NEW_MASTER_PAGE_TEXT = Messages.getString( "NewMasterPage.text" );
 
 	private SlotHandle slotHandle;
 
@@ -89,7 +93,13 @@ protected String getType( )
 	 */
 	public InsertAction( Object selectedObject )
 	{
-		this( selectedObject, TEXT );
+		this( selectedObject,
+				selectedObject instanceof SlotHandle
+						&& ( (SlotHandle) selectedObject )
+								.getSlotID( ) == IModuleModel.PAGE_SLOT
+						&& ( (SlotHandle) selectedObject )
+								.getElementHandle( ) instanceof ReportDesignHandle
+										? NEW_MASTER_PAGE_TEXT : INSERT_TEXT );
 	}
 
 	/**