Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not embed fop but add it as a dependency #674

Closed
wimjongman opened this issue Oct 30, 2021 · 5 comments · Fixed by #684
Closed

Do not embed fop but add it as a dependency #674

wimjongman opened this issue Oct 30, 2021 · 5 comments · Fixed by #684
Assignees
@wimjongman
Labels
IP REVIEW PENDING
Milestone
4.9

Comments

@wimjongman
Copy link
Contributor

Apache fop is embedded but it should be included.
@wimjongman wimjongman added this to the 4.9 milestone Oct 30, 2021
wimjongman added a commit that referenced this issue Oct 30, 2021
@wimjongman
Do not embed fop but add it as a dependency #674
964376a 
Moved FOP to target platform
@wimjongman wimjongman self-assigned this Nov 1, 2021
@wimjongman wimjongman linked a pull request Nov 1, 2021 that will close this issue
Do not embed fop but add it as a dependency #674 #675
Closed
wimjongman added a commit that referenced this issue Nov 2, 2021
@wimjongman
Do not embed fop but add it as a dependency #674
29ea50c 
Moved FOP to target platform
wimjongman added a commit that referenced this issue Nov 2, 2021
@wimjongman
Do not embed fop but add it as a dependency #674
bb01bfb 
More changes
wimjongman added a commit that referenced this issue Nov 2, 2021
@wimjongman
Do not embed fop but add it as a dependency #674
35eb5eb 
Trying with inclusion of fop
@wimjongman wimjongman linked a pull request Nov 2, 2021 that will close this issue
Do not embed fop but add it as a dependency #674 #684
Merged
wimjongman added a commit that referenced this issue Nov 3, 2021
@wimjongman
Do not embed fop but add it as a dependency #674 (#684)
3de35d0 
Trying with inclusion of fop
wimjongman added a commit that referenced this issue Nov 4, 2021
@wimjongman
Revert "Do not embed fop but add it as a dependency #674 (#684)"
5c98f46 
This reverts commit 3de35d0.
@wimjongman wimjongman linked a pull request Nov 4, 2021 that will close this issue
Revert "Do not embed fop but add it as a dependency #674" #687
Closed
@wimjongman wimjongman reopened this Nov 4, 2021
@wimjongman
Copy link
Contributor Author

IP REVIEW: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23815#c3

@ruspl-afed
Copy link
Contributor

@wimjongman Wim, I pinged them but still no movement there. Should we ask @waynebeaton to intensify this a bit?

@waynebeaton
Copy link
Contributor

Should we ask @waynebeaton to intensify this a bit?

I guess that this question answers itself. :-)

I'll see what I can do.

@ruspl-afed
Copy link
Contributor

@wimjongman please have a look at IP Team reply https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23815#c9

TBH I don't know the origin of the JAR that we currently have in our repository. But anyaway, are you OK if we remove some files from there?

@wimjongman
Copy link
Contributor Author

the review has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wimjongman wimjongman

Labels
IP REVIEW PENDING
Projects
None yet
Milestone
4.9
3 participants
@wimjongman @waynebeaton @ruspl-afed