Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign our builds #817

Closed
wimjongman opened this issue Feb 8, 2022 · 6 comments · Fixed by #827
Closed

Sign our builds #817

wimjongman opened this issue Feb 8, 2022 · 6 comments · Fixed by #827
Milestone

Comments

@wimjongman
Copy link
Contributor

wimjongman commented Feb 8, 2022

Before we can deliver our final release, we need to sign the binaries. For mac we need to notarize and created DMG's.

The signing process is described here:

https://wiki.eclipse.org/IT_Infrastructure_Doc#Sign_my_Jar.2Fplugins.2FWindows_exe.2FmacOS_App_files.3F

@wimjongman wimjongman added this to the 4.9 milestone Feb 8, 2022
wimjongman added a commit to wimjongman/birt that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 10, 2022
First attempt to sign.
wimjongman added a commit that referenced this issue Feb 11, 2022
First attempt to sign.
@wimjongman wimjongman linked a pull request Feb 11, 2022 that will close this issue
@wimjongman
Copy link
Contributor Author

Part 1 is done. The update site and executables are signed. Now I have to take a look at signing/notarizing the mac applications. It is not quite clear from the description ^^ how to do that.

@wimjongman
Copy link
Contributor Author

There are still some signing issues when installing BIRT from our snapshot update site [1]

image

[1] https://download.eclipse.org/birt/update-site/snapshot/

@wimjongman
Copy link
Contributor Author

@claesrosell any idea why the plugins above are unsigned? I would not expect that the jetty bundles are unsigned, nor any other content we fetch from maven.

@claesrosell
Copy link
Contributor

I think they are unsigned because the eclipse-jarsigner-plugin only signs bundles that are built and not dependencies. The above bundles are included in our features but pulled from the bundle pool ( our target platform ).
To solve this we would need to either ask the maintainers of the projects to sign the bundles (hard) or sign them our self via some Maven magic.
I found this, very old, Stackoverflow post: https://stackoverflow.com/questions/22541301/jarsigner-doesnt-sign-plugin-dependencies. Which mentions a workaround, if the problem indeed is what I think.

I am curious regarding the .source bundles in the screenshot. That must be a problem in some of our features / plugins.

@wimjongman
Copy link
Contributor Author

Yes, I will look into the source bundles.

I wonder why jetty is not signed. Do you think we should jump to 10.0.8 instead of the 10.0.6 we use now?

wimjongman added a commit to wimjongman/birt that referenced this issue Mar 16, 2022
Upgrade to Jetty 10.0.8
@wimjongman wimjongman linked a pull request Mar 16, 2022 that will close this issue
@wimjongman
Copy link
Contributor Author

Closing for 4.9 follow-up issue is Sign our builds #871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants