Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTLS] Removing/Disabling renegotiation feature #604

Closed
sbernard31 opened this issue Apr 9, 2018 · 5 comments
Closed

[DTLS] Removing/Disabling renegotiation feature #604

sbernard31 opened this issue Apr 9, 2018 · 5 comments
Labels
question scandium Voting

Comments

@sbernard31
Copy link
Contributor

The "Transport Layer Security (TLS) / Datagram Transport Layer Security (DTLS) Profiles for the Internet of Things" (RFC 7925) advices to disable renegociation feature.

Do you agree to remove it (which will clean the code) ? or should we add a way to disable it ?
(Personnally, I'm not even sure if this feature really works, I never tested it)
@boaks
Copy link
Contributor

boaks commented Apr 9, 2018

Votes for remove.

@boaks
Copy link
Contributor

boaks commented Apr 9, 2018

Votes for configure.

@boaks boaks added the Voting label Apr 9, 2018
@jimsch
Copy link

jimsch commented Apr 16, 2018

Given that this is not doable in DTLS 1.3, I see no reason to keep it.

@boaks
Copy link
Contributor

boaks commented Apr 16, 2018

@jimsch
The idea was, to add a vote for "remove" or "configure" in the comments above :-).
But OK, you seems to agree on "remove".

sbernard31 added a commit that referenced this issue Apr 25, 2018
@sbernard31
#604: add tests about HELLO_REQUEST reception message.
0020cce
sbernard31 added a commit that referenced this issue Apr 25, 2018
@sbernard31
#604: refuse HELLO_REQUEST (answer with NO_RENEGOCIATION)
2a215c3
sbernard31 added a commit that referenced this issue Apr 25, 2018
@sbernard31
#604: add tests about not allowed renegotiation.
2877449
sbernard31 added a commit that referenced this issue Apr 25, 2018
@sbernard31
#604: Refuse renegotiation at server side.
ac0f334
@sbernard31 sbernard31 mentioned this issue Apr 25, 2018
Merged
sbernard31 added a commit that referenced this issue Apr 26, 2018
@sbernard31
#604: refuse HELLO_REQUEST (answer with NO_RENEGOCIATION)
586bcf3
sbernard31 added a commit that referenced this issue Apr 26, 2018
@sbernard31
#604: add tests about not allowed renegotiation.
dd8658a
sbernard31 added a commit that referenced this issue Apr 26, 2018
@sbernard31
#604: Refuse renegotiation at server side.
576d063
sbernard31 added a commit that referenced this issue May 2, 2018
@sbernard31
#604: add tests about HELLO_REQUEST reception message.
990708f
sbernard31 added a commit that referenced this issue May 2, 2018
@sbernard31
#604: refuse HELLO_REQUEST (answer with NO_RENEGOCIATION)
0548878
sbernard31 added a commit that referenced this issue May 2, 2018
@sbernard31
#604: add tests about not allowed renegotiation.
f7fffc0
sbernard31 added a commit that referenced this issue May 2, 2018
@sbernard31
#604: Refuse renegotiation at server side.
1d417e7
sbernard31 added a commit that referenced this issue May 3, 2018
@sbernard31
#604: add tests about HELLO_REQUEST reception message.
3974375
sbernard31 added a commit that referenced this issue May 3, 2018
@sbernard31
#604: refuse HELLO_REQUEST (answer with NO_RENEGOCIATION)
7c90b53
sbernard31 added a commit that referenced this issue May 3, 2018
@sbernard31
#604: add tests about not allowed renegotiation.
63434ae
sbernard31 added a commit that referenced this issue May 3, 2018
@sbernard31
#604: Refuse renegotiation at server side.
d58cc9f
@sbernard31
Copy link
Contributor Author

sbernard31 commented May 3, 2018 •
edited

#618 is integrated in 2.0.x branch.
(renegotiation is not allowed anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question scandium Voting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbernard31 @jimsch @boaks