Fix logging of MID matching. #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boaks
force-pushed
the
fix_cluster_notify
branch
2 times, most recently
from
d3bddba
to
baeaf81
Compare
|
Intended for issue #668 |
boaks
force-pushed
the
fix_cluster_notify
branch
2 times, most recently
from
9cd768e
to
e9cdd8b
Compare
sbernard31
reviewed
Oct 2, 2018
| @@ -112,6 +112,7 @@ public void sendRequest(final Exchange exchange) { | |||
| // for observe request. | |||
| Request request = exchange.getCurrentRequest(); | |||
| if (request.isObserve() && 0 == exchange.getFailedTransmissionCount()) { | |||
| exchangeStore.assignMessageId(request); | |||
There was a problem hiding this comment.
Should we handle the case where assignMessageId returns Message.NONE ?
Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
boaks
force-pushed
the
fix_cluster_notify
branch
from
e9cdd8b
to
0f00d6a
Compare
|
Check for exhausted MID added. |
|
👍 |
|
So in some time in the future, we hopefully will see, what caused the warning of #668. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated request from observation stores may not have a valid MID.
Signed-off-by: Achim Kraus achim.kraus@bosch-si.com