[2208] CCE when using Show/Hide Functional Exchanges tool

Bug: 2208
Change-Id: Id7b56afeb9ac02c6919bb2ad24c67d3286056194
Signed-off-by: Tu Ton <minhtutonthat@gmail.com>

core/plugins/org.polarsys.capella.core.sirius.analysis/src/org/polarsys/capella/core/sirius/analysis/FaServices.java

@@ -290,7 +290,7 @@ public List<FunctionalExchange> getAvailableFunctionalExchangesToInsert(DSemanti
    *         (DataFlow Blank Diagrams) used in oa, logical, context, physical
    */
   public Collection<FunctionalExchange> getDisplayedFunctionalExchanges(DSemanticDecorator selectedElement) {
-    Collection<FunctionalExchange> result = new HashSet<FunctionalExchange>();
+    Collection<FunctionalExchange> result = new HashSet<>();
     // current DiagramElements
     if (selectedElement instanceof AbstractDNode) {
       result = getDisplayedFunctionalExchangesFromAbstractDNode((AbstractDNode) selectedElement);
@@ -313,7 +313,9 @@ public Collection<FunctionalExchange> getDisplayedFunctionalExchanges(DSemanticD
       }
     }
 
-    return result;
+    // This cast to ArrayList is necessary since this method is also used in Transfer Wizard service which expects a
+    // List as parameter
+    return new ArrayList<>(result);
   }
 
   /**