Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

1.3.4 Release commits #7460

Closed
Voiteh opened this issue Jan 29, 2020 · 8 comments
Closed

1.3.4 Release commits #7460

Voiteh opened this issue Jan 29, 2020 · 8 comments

Comments

@Voiteh
Copy link
Contributor

Voiteh commented Jan 29, 2020

This issue hold information on what has been reviewed and needs to be reviewed before 1.3.4 release can happen. To contribute take a commit from list located below refering to https://github.com/eclipse/ceylon/tree/_old/master branch
You can search commits on github by https://github.com/eclipse/ceylon/commit/{commitID}
Important aspect is to exlclude braking changes so we don't include them into release.
After review include information.
a) what have been reviewed,
b) the sort of things You were looking for
c) a list of commits You are concerned about and the reason

List will be updated with new comments

+ |b50d4cc544| Removed unused file with special copyright   |
+ |4696905f91| Fixed copyright dates  |
+ |8bbbd3de7c|   fix #7207 - ugly hack  |
+ |3bb3c747fe|   Merge pull request #7293 from CPColin/patch-1 Restored package and import statements |
+ |627d930818|   Restored package and import statements - Should fix a build error that popped up when the copyright info was deleted.  |
+ |f33f6f5b35| Added copyright headers to Ceylon files  |
+ |62550630d0| Added ASL copyright headers to please Eclipse  |
+ |82eea966a5| Added missing copyright headers in compile-java/langtools   |
+ |87975a11fc| Removed extraneous licence/copyright headers   |
+ |ec3e9d7dc1|  Removed various bogus copyright headers   |
+ |44b9436cfd|   fix #7281 qualify callable parameter field ref by 'this' if necessary                                  |
+ |25efd6af69| Compiler java - refactor - use method of Unit  |
+ |642a99fdd3|Simplification and fix for is operation - js backend|
+ |2a5d4cc7c9| switch - spec for 'else case' in expressions  |
- |75bd6dd0cc|Fixed a path to ceylon-ide-eclipse - ECLIPSE RENAME |
- |1cb4dbd08b| Merge branch 'master' of github.com:ceylon/ceylon - ECLIPSE RENAME|
+ |bff38757c4|Reapplied fix for release script regression  |
- |7bd1d180a5| Merge branch 'eclipse-rename'  - ECLIPSE RENAME|
+ |49b70043d8| Fix regression introduced by release script  |
- |0cb09097dc|Renamed to org.eclipse - ECLIPSE RENAME|
- |5ee323bc2c|fix docs for fold() and scan() #7255 - Breaking change !  |
! |60cdc1db34|Moved transaction module from SDK - Not sure seems like breaking change |
+ |d2fb43c73c|Metamodel: ignore model annotations like `@NotNull`  |
- |88062222ae| Fold changed signature  for #7255- Breaking change !  |
+ |5e0b527205| Ignored compat tests that I can't fix for now  |
+ |0a474c0b0f| work on #7142 |
+ |f33a1c309a| clear things up |
- |822a70a314| update test with new API - for #7255- Breaking change ! |
+ |c263c3aead| fix error message for non-disjoint 'of' types   |
+ |6d259f66dd| fix #7257 types with self types represented as enumerated  |
+ |61b7824c2b|handle something realy weird that can happen in IntelliJ |
- |e0665d90e4| uncurry fold() and scan() for #7255- Breaking change !    |
+ |6d7254baef| test for #7256 |
+ |bc5f27931d|fix #7256 String.repeat() with nagative argument on JS |
- |cdd0d8b10c|fix code snippet in docs - docs for #7255|
- |23cff5a46d|uncurry utility functions for #7255|
+ |929314d55d|test for #7237 |
+ |d284105b5a| hacked up fix to #7254 |
+ |c48958b282| allow syntax function { ... } and void { ... } for #7190 |
+ |9d366f924c| fix secons AIOOBE associated with #7251 |
+ |7f2871f19c| oops, fix test #7251 |
+ |5e2004f27d| There is no then in a case expression (#7253)  |
+ |2c2e87de3a| fix stupid bug in lowercasing of type name  |
+ |c84fc7c5f2| fix an AIOOBE resulting from work on #7251 |
+ |21cff8a217| improve overload resultion with 'object' expr arguments  |
+ |9c53a31637| add a test for #7251 |
+ |239e07c899| rework of function ref type arg inference for #7251 ,cleaner/more correct impl of #6701 |
+ |141e004cd3| improvements and tests for #7251 |
+ |f4b286b23d| cleanups after #7190 |
+ |7f892ba8cb| Use RententionPolicy.RUNTIME on Nullable and NonNull, otherwise they can’t be accessed using reflection which makes them basically useless.  #6850|
+ |5c28e0f1c5|use inferred type args to infer argument parameter types #7251 |
+ |d09daf2dd3| fixes to token handling, and support for navigation for #7190  |
+ |8d05c2b736| parameter list inference for anonymous functions #7190 includes an improved algorithm for assigning names to parameters of SAMs |
+ |877f6d0a91|  rename parameter  |
+ |f229d45145|fix indentation |
+ |581f127407|fix bug with unshared static interface members #7250 |
+ |af39765f4b|  static attributes in interfaces with initialisers #7179  |
+ |9c24da7364|   clean up imports  |
+ |bfb7603b21| fix case reordering for #4402 |
+ |557bee96e9|  @nullable annotation on fields too #6850 |
+ |f62e93cb9a| very minor - return in `if` rather than via declared variable after `if`          |
+ |aeebde85ed|  simplify isAnything implementation  |
+ |4ae1cff60a|  more consistent behavior in contravariant case #6701 and fix an npe |
+ |6e75abb177|  better type inference for instantiations occurring as arguments #6701 mainly helps with invariant types |
+ |952dbbb882| fix a little issue introduced by #6701 it only showed up with Java backend enabled |
+ |42e727a907| type arg inference for stuff like Collectors.toList() #6701 |
+ |fd0c029576|future proof against dollarcurlies - This seems like continuation of #7243 |
+ |7fb3ab46bb|treat nullary functions more like values for type arg inference #6701 |
+ |2c01122c07| better solution to #7242 unpack tuple elements in spread arg when inferring type args  |
+ |e8b844adc7| remove use of old pre-#4402 case (is T) syntax from spec  |
+ |137cfd4354|another test for #4402  |
+ |3181dab23d| spec for #4402  |
+ |59c95575da|add a missing check for #4402 |
+ |1cec4fce3e| test for #7243    |
+ |198597cf3a|typechecker tests for #4402  |
+ |3dc9603346| add a test for #4402  |
+ |d43170e442| Revert "test for #4402"   |
+ |e88290f027|test for #4402 |
+ |c192838d32| handle Null case correctly for #4402 |
+ |a49fed4ebc|add backend tests for #4402|
+ |0ad9321324| don't add extra newline at end of resources in case where there is no newline at end of file |
+ |be3030f788| fix failing test caused by 4c45a73|
+ |0b30716adb| no need for fully-qualified name |
+ |b06373b4b5| minor code change|
+ |a130339d4a| Fix exception test   |
! |8610d77959| use Util to setup args - this seems like continuation of #5632   |
+ |4c45a73508|stop messing with the text of the tokens #7243 |
+ |5ce2b6e2a6|more fixes for #7243 |
+ |1134415031| fix scanning of string token for interpolated expression #7243  |
+ |441b91f052|handle chars discarded by the lexer #7243 |
+ |123f00d1cf|backend tests for #7220 let statements |
+ |8aedba141d| disable test which I don't believe belongs in backend test suite |
+ |a2e1a387b6|make lexer handle lone # more elegantly|
+ |a66c55f203| better fix for #7235|
+ |47d8ac7c2f|  disallow catching or narrowing to RuntimeException temporary solution to #7235|
+ |23be388169| minor changes in code |
+ |22412e6785| Revert "disllow imports of java.lang.RuntimeException for #7235"  |
+ |9aed4083d6|Revert "fix error message for #7235" |
+ |2237311095| fix stop/start indices in lexer wrapper when there are escaped idents #7243 |
+ |617be24d2d|  don't split string token on \( without matching ) #7243  |
+ |af961af15b| remove done todo  |
+ |3a01bcf5ed|  add tests cos the language module tests caught a bug in the typechecker  |
+ |582b890a59| Revert "proposed solution to #7242"  |
! |50da63a0d1|  Moar test fixes - not sure                                  |
! |0615c921b9|   Moar test fixes - not sure      |
+ |fac381c2d1| This error is handled in the frontend now   |
! |a86b432898|Further test fixes |
! |cbc5d75de8|Changes in tests - not sure about this|
! |9da125648f| List API changes in tests - not sure about this one|
! |52dd7fa23e|  Changed tests due to process change in setting up program arguments - this seems like continuation of #5632 |
+ |61dfe359bb| Tests versions bump to 1.3.4-SNAPSHOT  |
+ |3357228f99|Fixed compilation - change method visibility to protected -> public|
+ |ff09af8594|make a useful method public |
+ |35bdba642d| move a backend check to the typechecker |
+ |c65a4cb9c3|proposed implementation of new syntax for string interpolation #7243|
+ |d49523342a| remove redundant parens  |
! !!!|11408ad504|add since() annotations with provisional version number <--- this requires change in version numbering to 1.3.4|
+ |531136aef8|add module titles to 'ceylon doc' #7193|
+ |15a1a7c640|tabs to spaces |
+ |5f9f8cda56|initial impl of label annotation #7193|
+ |35b1c44d42|align &s |
+ |854282dc1a| proposed solution to #7242|
+ |02f3688dfe|align &&s and ||s  |
+ |1a7353c17c|fix quoting in error message |
+ |b3970939fe|basic implementation of #4402, unified syntax for type and value cases  |
+ |41310e9f14| add a test   #6455|
+ |551f09fddf| disallow or define semantics for "default late" values #6455 |
+ |ab68a1bf64|fix indentation |
+ |4212a71647|fix 'shared restricted' constructors not working on the JVM #7237|
+ |96b1fa3243| Fix the throwable type definition import|
+ |75e799f06b| make the typechecker happy |
+ |dfb704b3c0|fix a minor bug in resource loading |
+ |63d5a1730a|also handle .txt explicitly 'cos that is what ceylon.locale uses  |
+ |0d12825a15|refactor out a function |
+ |b3d44e5f02|fix error message for #7235|
+ |54f1bd59e8|disllow imports of java.lang.RuntimeException for #7235|
+ |2aae7c1a61|  persist certain resources into the module's .js file for #6034 #6795 #1398|
- |0a21ef0db2| avoid importing stuff from hidden packages because it tripped up 'ceylon doc' continuation of ddb97d18ce - process braking change!|
+ |0973395837|fix misleading message |
+ |70bbe06931| handle setters which are refined by attributes in Java |
+ |73e0db7f93|fix an indexing bug in Type + rename lots of local vars |
+ |8f2ea7a7ca|very minor  |
+ |d519569f4c|missing final, reorder params  |
+ |c1f741bc52|light refactoring: extract methods |
+ |2b2c40c365| fix #7222 typing of shortcut refinement of generic methods via assignment|
+ |51331b35c5|  cut down on some error messages improve some error message text formatting changes |
+ |92269f2f9f| tests for #7122 |
+ |ae990771f6|  fix #7232   |
! |3803f25a5f| fix warning message - not applicable as patch|
- |927d938479| warning if you catch something that is not an Exception #7234  - Breaking change|
+ |600a77fee8| add see() annotation  to Throwable class|
+ |f224495b8e| disable tests for now  |
+ |1c9a780397|  fix #7122  |
+ |64e7c6832c| test #7122 |
+ |cc3d01b8b2|  whitespace  |
+ |046a4d7a7e| workaround for IntelliJ model loader bug eclipse/ceylon-ide-intellij#649  |
- |0714912c7c| minimize dynamic blocks #5632  - breaking change|
- |cb1f92e365| clean up native impl of process #5632 - breaking change|
- |ddb97d18ce|make the typechecker tests accept process |
+ |e9391c6116|  remove code duplication  |
+ |abefa79d75|members of native 'object' impls not checked #7231|
+ |c8f66048a9|fix formatting |
- |5057623dc6|fix a silly indexing bug -seems like continuation of  #5632 - breaking change |
- |8078705137|much more typesafe native-js impl of process #5632 - breaking change|
- |20cc493bdd|  port more process-related JS code to Ceylon  -seems like continuation of  #5632 - breaking change|
- |2e07c12d6a| first step of native("js") impl of process #5632- breaking change! |
- |a46b7c9f74|  first step of native("js") impl of process #5632 - breaking change! |
+ |8403b78d38| remove two native-related errors that are unnecessary   |
- |223ce11d66|native Ceylon implementation of process! #5632 -breaking change|
+ |90e2521b29| clean import |
+ |7b2128c8cc|add an extra test  |
+ |0e567ae619|fix String after change to corresponding() |
+ |1c8865478d| add eachPair() function  |
- |02bc925961|curry functions for stream processing that accept an anon function|
+ |198fad0407| Added a ‘nonbean’ annotation to skip JPA constructors (#6620)  |
- |41f8f0b668|fix tests after change to concatenate()  |
- |91cead3eaf| split out parseBooleanInternal for #7012- breaking change ! |
- |b03e9a63fe|also undeprecate parseBoolean() #7012 (JV: parseBoolean's arg changed to String?; |
- |3db83fd45a| correctly-typed emptiness for concatenate() and sort() fixes #7028 - breaking change!  |
- |869d0d8878|more precise type for List.exceptLast() #5641 - breaking change!|
- |ed753fda79| fix messed up merge  |
- |e8ff03e00f|undeprecate parseInteger() / parseFloat() #7012 - breaking change!|
! |f34ad2e86a|Revert "Revert "narrow type of String.exceptLast + fix impl of String… - this confusing I'm not sure do we introduce breaking change with this one |
- |37cfeee390|finally fix #6063 & #7117 - breaking change!|
! |353c4f4590|  I'm pretty sure .poms should be copied into the temp dir noticed while working on #7225 - this is continuation but don't seems to harm 1.3.4 |
+ |b8f8f8b214|minor cleanups -code formatting|
- |ccda218127|  probably-wrong solution to #7225 - this wasn't fixed |
+ |b5428a9d06|minor changes - code formattig   |
+ |e237d7e7a8|make message less confusing  |
+ |6e46fdd40b|squash warning - unchecked for CeylonModuleLoader|
+ |ee035a774b|fix whitespace - code formattig |
+ |ddd7feb319|fix for #7226|
+ |72ba3804b9|minor changes  - code formatting|
+ |2e98073bfc| Revert "add abbreviation for --run, for consistency with run/run-js"  |
+ |a8d35f1a22|clean import |
+ |62979a0c15|add abbreviation for --run, for consistency with run/run-js |
+ |48697f9b80| fix spans for declaration refs |
+ |72681b4c23|clarifications of reference expressions #7218 ? |
+ |5d6e998ce2| I'm not sure about this one it seems like some fix for #7218|
+ |104c3b3b86| update spec intro  |
+ |af1a80e380|spec update for #7218|
+ |6715168f56|new syntax for model and declaration references #7218 - merge|
+ |6cc5e201cd|allow old syntax for compiler annotations |
+ |b66ee9d7c1|improve error message |
+ |ea4b884ec5|light refactoring of checkIsExactlyOnOf() stuff |
+ |95c8c8eaec|get rid of error text about strict null checking |
+ |6ca95b1a8d|improve error messages  |
+ |924d93207d|fix String.lastIndex on JS #7221|
+ |dc9608510c|parentesies  removal|
+ |30b5afc223| tests for transpose() #7217 |
+ |659fcd2a23| 659fcd2a23 |
+ |dfc3bc1887|fix npe in grammar for #7220|
+ |4796ac2563|   make parser much more tolerant of empty statements     |
+ |6798efd00e|update spec for #7220|
+ |02223051bd| Merge branch '7220' |
+ |0c7a6e460c|hack to make #7220 syntax compile correctly on both backends|
+ |06859f0486|Revert "tests for 7220" |
+ |13742e5d62|tests for 7220 |
+ |db53d11903|use 'let' instead of 'value' for destructuring statements #7220|
+ |303345c14c|use ^ instead of @ for model refs #7218|
+ |be85c7146e|fix parsing of refs to current module/package/class/interface for #7218|
+ |a33c804e7b|Fixed duplicate LocalDeclaration annotations introduced in 3af1e3a|
+ |de5b69194f|@jvasileff's alternate impl of transpose() |
+ |d3fdad4106|fixes to transpose() impl in ad3996d #7217|
+ |c5d2fc77e0|#7218- increase precedence of new meta syntax|
+ |6482d414c9|Fixed duplicate LocalDeclaration annotations introduced in 3af1e3a|
+ |7c4279c0a4|fix erasure of Boolean |
+ |4d0714deb0|fix erasure of Boolean |
+ |71d08d53a9|extract a local|
+ |bd0371252b|#7218 - use new declaration ref syntax in language model doc annotations |
+ |1232190e06|#7218 - simplified metamodel syntax|
+ |60327c2d9e|#7218 - change syntax for compiler annotations, to free up @ |
+ |03a7b4bb40|Improve transpose() documentation |
+ |d1bd236b9a|fix #7212 bogus error message |
+ |2a1bed46ad|remove more obsolete methods - code cleanup for java backend
+ |3af1e3a312|simplify Java backend, using model APIs directly - code cleanup for java backend|
+ |d636e01053|add missing jar for compiler-js|
+ |62bd513a65|minor cleanups |
+ |1fb98d4176|minor cleanups |
+ |52bf5f7dcf|rescue more changes from 7037 branch. This is not implementation of #7037                             |
+ |dec690c3f5| Added a new section for `ceylon/ceylon-examples-web` to the RELEASE document|
+ |b24025cd0f|rescue more changes from 7037 branch. This is not implementation of #7037 |
+ |b091d87146|Added missing update instructions for "ceylon-docker/s2i-ceylon" |
+ |e2fe3bf205|rescue more minor changes from the 7037 branch. This is not implementation of #7037|
+ |c8f1b3d880| place tests outside loop - performance improvement in typechecker |
+ |e722fb3ba8|rescue a bunch of minor changes from the 7037 branch . This is not implementation of #7037, this provides just util functions and some formating improvements|
+ |fcf626bbbb| fix #7211 inferred refinements and return |
+ |74cc1d1995|fix #7211 inferred refinements and return|
+ |ba22c6d0de|gitignore bin dir in tools|
+ |8fd303185b|tests for #7211|
+ |b014585a36|update gitignore for typechecker + test/play|
+ |ad3996d154| transpose() function #7217|
+ |644613acae|one last fix for #6316|
+ |41c0f818c7|Updated SDKMan script |
+ |77bdda1c2b|clean up material on conditions and fix #7206|
+ |764ef27f1e|roll back d5207f5 and refix #6316|
+ |831ead2c7d|Fixed herd build for release |
+ |0710157b4a|change spec here, since [Nothing+] is an empty type |
+ |546ecb1794|fix tests |
+ |08432493a4|fix tests |
+ |899872e1c0|downgrade error to warning for consistency with exists/nonempty |
+ |da185070c7|remove comma in spec|
+ |7fec4c5ed7|spec for #7204|
+ |c7eb45cedb|fix whitespaces in spec|
+ |5fddd9475f|unsound 'if(!nonempty [] x = ...)' accepted typechecker #7204|
+ |407c6b8bb2|add some tests for nonempty |
+ |433bf5c7f9|fix spec for nonempty|
+ |9b04a11528|add warning for 'if (nonempty e = [])'  in typechecker|
+ |ef80196873|renaming methods in typechecker|
+ |9bf38d3458|improve error message|
+ |ec8a1ad72d|improve error message |
+ |0d58bc6963|Typo/grammar fixes in statements/block chapter (#7202) |
+ |616d95a|improve doc of Iterable.paired |
+ |d5207f578d|temporary fix because the fix to #6316|
+ |5880feba99| Fixes of toString() for constructor and function|
+ |011da2658c|cleanup after cleanup :) |
+ |a14f34820f|minor code cleanups |
+ |cc55b3e613|Docs -function → value for formal attributes (typo) (#7200) |
+ |ca28dedfc4| Docs- fix return type in example (#7199)  |
+ |8eebe38cb9|optimize more methods of Type for Tuple + fix isReified() #6316|
+ |2f77882bd9|optimize Type.equals()/hashCode() for #6316|
+ |1f0144daef |Initial fix for #6316 - stack overflow with very long tuples|
+ |0ae476a635| Cleanup unused import |
+ |2989e5ffec| New development phase of 1.3.4, changes in versions |
+ |e081da2b63| NPE fix |                    
Reviewed ☑ / Rejected ☒ Commit comment / concern / issue reference
b50d4cc Removed unused file with special copyright
4696905 Fixed copyright dates
8bbbd3d fix #7207 - ugly hack
3bb3c74 Merge pull request #7293 from CPColin/patch-1 Restored package and import statements
627d930 Restored package and import statements - Should fix a build error that popped up when the copyright info was deleted.
f33f6f5 Added copyright headers to Ceylon files
6255063 Added ASL copyright headers to please Eclipse
82eea96 Added missing copyright headers in compile-java/langtools
87975a1 Removed extraneous licence/copyright headers
ec3e9d7 Removed various bogus copyright headers
44b9436 fix #7281 qualify callable parameter field ref by 'this' if necessary
25efd6a Compiler java - refactor - use method of Unit
642a99f Simplification and fix for is operation - js backend
2a5d4cc switch - spec for 'else case' in expressions
75bd6dd Fixed a path to ceylon-ide-eclipse - ECLIPSE RENAME
1cb4dbd Merge branch 'master' of github.com:ceylon/ceylon - ECLIPSE RENAME
bff3875 Reapplied fix for release script regression
7bd1d18 Merge branch 'eclipse-rename' - ECLIPSE RENAME
49b7004 Fix regression introduced by release script
0cb0909 Renamed to org.eclipse - ECLIPSE RENAME
5ee323b fix docs for fold() and scan() #7255 - Breaking change !
! 60cdc1d Moved transaction module from SDK - Not sure seems like breaking change
d2fb43c Metamodel: ignore model annotations like @NotNull
8806222 Fold changed signature for #7255- Breaking change !
5e0b527 Ignored compat tests that I can't fix for now
0a474c0 work on #7142
f33a1c3 clear things up
822a70a update test with new API - for #7255- Breaking change !
c263c3a fix error message for non-disjoint 'of' types
6d259f6 fix #7257 types with self types represented as enumerated
61b7824 handle something realy weird that can happen in IntelliJ
e0665d9 uncurry fold() and scan() for #7255- Breaking change !
6d7254b test for #7256
bc5f279 fix #7256 String.repeat() with nagative argument on JS
cdd0d8b fix code snippet in docs
23cff5a uncurry utility functions for #7255
929314d test for #7237
d284105 hacked up fix to #7254
c48958b allow syntax function { ... } and void { ... } for #7190
9d366f9 fix secons AIOOBE associated with #7251
7f2871f oops, fix test #7251
5e2004f There is no then in a case expression (#7253)
2c2e87d fix stupid bug in lowercasing of type name
c84fc7c fix an AIOOBE resulting from work on #7251
21cff8a improve overload resultion with 'object' expr arguments
9c53a31 add a test for #7251
239e07c rework of function ref type arg inference for #7251 ,cleaner/more correct impl of #6701
141e004 improvements and tests for #7251
f4b286b cleanups after #7190
7f892ba Use RententionPolicy.RUNTIME on Nullable and NonNull, otherwise they can’t be accessed using reflection which makes them basically useless. #6850
5c28e0f use inferred type args to infer argument parameter types #7251
d09daf2 fixes to token handling, and support for navigation for #7190
8d05c2b parameter list inference for anonymous functions #7190 includes an improved algorithm for assigning names to parameters of SAMs
877f6d0 rename parameter
f229d45 fix indentation
581f127 fix bug with unshared static interface members #7250
af39765 static attributes in interfaces with initialisers #7179
9c24da7 clean up imports
bfb7603 fix case reordering for #4402
557bee9 @nullable annotation on fields too #6850
f62e93c very minor - return in if rather than via declared variable after if
aeebde8 simplify isAnything implementation
4ae1cff more consistent behavior in contravariant case #6701 and fix an npe
6e75abb better type inference for instantiations occurring as arguments #6701 mainly helps with invariant types
952dbbb fix a little issue introduced by #6701 it only showed up with Java backend enabled
42e727a type arg inference for stuff like Collectors.toList() #6701
fd0c029 future proof against dollarcurlies - This seems like continuation of #7243
7fb3ab4 treat nullary functions more like values for type arg inference #6701
2c01122 better solution to #7242 unpack tuple elements in spread arg when inferring type args
e8b844a remove use of old pre-#4402 case (is T) syntax from spec
137cfd4 another test for #4402
3181dab spec for #4402
59c9557 add a missing check for #4402
1cec4fc test for #7243
198597c typechecker tests for #4402
3dc9603 add a test for #4402
d43170e Revert "test for #4402"
e88290f test for #4402
c192838 handle Null case correctly for #4402
a49fed4 add backend tests for #4402
0ad9321 don't add extra newline at end of resources in case where there is no newline at end of file
be3030f fix failing test caused by 4c45a73
0b30716 no need for fully-qualified name
b06373b minor code change
a130339 Fix exception test
! 8610d77 use Util to setup args - this seems like continuation of #5632
4c45a73 stop messing with the text of the tokens #7243
5ce2b6e more fixes for #7243
1134415 fix scanning of string token for interpolated expression #7243
441b91f handle chars discarded by the lexer #7243
123f00d backend tests for #7220 let statements
8aedba1 disable test which I don't believe belongs in backend test suite
a2e1a38 make lexer handle lone # more elegantly
a66c55f better fix for #7235
47d8ac7 disallow catching or narrowing to RuntimeException temporary solution to #7235
23be388 minor changes in code
22412e6 Revert "disllow imports of java.lang.RuntimeException for #7235"
9aed408 Revert "fix error message for #7235"
2237311 fix stop/start indices in lexer wrapper when there are escaped idents #7243
617be24 don't split string token on ( without matching ) #7243
af961af remove done todo
3a01bcf add tests cos the language module tests caught a bug in the typechecker
582b890 Revert "proposed solution to #7242"
! 50da63a Moar test fixes - not sure
! 0615c92 Moar test fixes - not sure
fac381c This error is handled in the frontend now
! a86b432 Further test fixes
! cbc5d75 Changes in tests - not sure about this
! 9da1256 List API changes in tests - not sure about this one
! 52dd7fa Changed tests due to process change in setting up program arguments - this seems like continuation of #5632
61dfe35 Tests versions bump to 1.3.4-SNAPSHOT
3357228 Fixed compilation - change method visibility to protected -> public
ff09af8 make a useful method public
35bdba6 move a backend check to the typechecker
c65a4cb proposed implementation of new syntax for string interpolation #7243
d495233 remove redundant parens
!!!! 11408ad add since() annotations with provisional version number <--- this requires change in version numbering to 1.3.4
531136a add module titles to 'ceylon doc' #7193
15a1a7c tabs to spaces
5f9f8cd initial impl of label annotation #7193
35b1c44 align &s
854282d proposed solution to #7242
02f3688 align &&s and
1a7353c fix quoting in error message
b397093 basic implementation of #4402, unified syntax for type and value cases
41310e9 add a test #6455
551f09f disallow or define semantics for "default late" values #6455
ab68a1b fix indentation
4212a71 fix 'shared restricted' constructors not working on the JVM #7237
96b1fa3 Fix the throwable type definition import
75e799f make the typechecker happy
dfb704b fix a minor bug in resource loading
63d5a17 also handle .txt explicitly 'cos that is what ceylon.locale uses
0d12825 refactor out a function
b3d44e5 fix error message for #7235
54f1bd5 disllow imports of java.lang.RuntimeException for #7235
2aae7c1 persist certain resources into the module's .js file for #6034 #6795 #1398
0a21ef0 avoid importing stuff from hidden packages because it tripped up 'ceylon doc' continuation of ddb97d1 - breaking change
0973395 fix misleading message
70bbe06 handle setters which are refined by attributes in Java
73e0db7 fix an indexing bug in Type + rename lots of local vars
8f2ea7a very minor
d519569 missing final, reorder params
c1f741b light refactoring: extract methods
2b2c40c fix #7222 typing of shortcut refinement of generic methods via assignment
51331b3 cut down on some error messages improve some error message text formatting changes
92269f2 tests for #7122
ae99077 fix #7232
! 3803f25 fix warning message - not applicable as patch
927d938 warning if you catch something that is not an Exception #7234 - Breaking change
600a77f add see() annotation to Throwable class
f224495 disable tests for now
1c9a780 fix #7122
64e7c68 test #7122
cc3d01b whitespace
046a4d7 workaround for IntelliJ model loader bug eclipse-archived/ceylon-ide-intellij#649
0714912 minimize dynamic blocks #5632 - breaking change
cb1f92e clean up native impl of process #5632 - breaking change
ddb97d1 make the typechecker tests accept process - breaking change
e9391c6 remove code duplication
abefa79 members of native 'object' impls not checked #7231
c8f6604 fix formatting
5057623 fix a silly indexing bug -seems like continuation of #5632 - breaking change
8078705 much more typesafe native-js impl of process #5632 - breaking change
20cc493 port more process-related JS code to Ceylon -seems like continuation of #5632 - breaking change
2e07c12 first step of native("js") impl of process #5632- breaking change!
a46b7c9 first step of native("js") impl of process #5632 - breaking change!
8403b78 remove two native-related errors that are unnecessary
223ce11 native Ceylon implementation of process! #5632 -breaking change
90e2521 clean import
7b2128c add an extra test
0e567ae fix String after change to corresponding()
1c88654 add eachPair() function
02bc925 curry functions for stream processing that accept an anon function
198fad0 Added a ‘nonbean’ annotation to skip JPA constructors (#6620)
41f8f0b fix tests after change to concatenate()
91cead3 split out parseBooleanInternal for #7012- breaking change !
b03e9a6 also undeprecate parseBoolean() #7012 (JV: parseBoolean's arg changed to String?;
3db83fd correctly-typed emptiness for concatenate() and sort() fixes #7028 - breaking change!
869d0d8 more precise type for List.exceptLast() #5641 - breaking change!
ed753fd fix messed up merge
e8ff03e undeprecate parseInteger() / parseFloat() #7012 - breaking change!
! f34ad2e Revert "Revert "narrow type of String.exceptLast + fix impl of String… - this confusing I'm not sure do we introduce breaking change with this one
37cfeee finally fix #6063 & #7117 - breaking change!
! 353c4f4 I'm pretty sure .poms should be copied into the temp dir noticed while working on #7225 - this is continuation but don't seems to harm 1.3.4
b8f8f8b minor cleanups -code formatting
ccda218 probably-wrong solution to #7225 - this wasn't fixed
b5428a9 minor changes - code formattig
e237d7e make message less confusing
6e46fdd squash warning - unchecked for CeylonModuleLoader
ee035a7 fix whitespace - code formattig
ddd7feb fix for #7226
72ba380 minor changes - code formatting
2e98073 Revert "add abbreviation for --run, for consistency with run/run-js"
a8d35f1 clean import
62979a0 add abbreviation for --run, for consistency with run/run-js
48697f9 fix spans for declaration refs
72681b4 clarifications of reference expressions #7218 ?
5d6e998 I'm not sure about this one it seems like some fix for #7218
104c3b3 update spec intro
af1a80e spec update for #7218
6715168 new syntax for model and declaration references #7218 - merge
6cc5e20 allow old syntax for compiler annotations
b66ee9d improve error message
ea4b884 light refactoring of checkIsExactlyOnOf() stuff
95c8c8e get rid of error text about strict null checking
6ca95b1 improve error messages
924d932 fix String.lastIndex on JS #7221
dc96085 parentesies removal
30b5afc tests for transpose() #7217
659fcd2 659fcd2
dfc3bc1 fix npe in grammar for #7220
4796ac2 make parser much more tolerant of empty statements
6798efd update spec for #7220
0222305 Merge branch '7220'
0c7a6e4 hack to make #7220 syntax compile correctly on both backends
06859f0 Revert "tests for 7220"
13742e5 tests for 7220
db53d11 use 'let' instead of 'value' for destructuring statements #7220
303345c use ^ instead of @ for model refs #7218
be85c71 fix parsing of refs to current module/package/class/interface for #7218
a33c804 Fixed duplicate LocalDeclaration annotations introduced in 3af1e3a
de5b691 @jvasileff's alternate impl of transpose()
d3fdad4 fixes to transpose() impl in ad3996d #7217
c5d2fc7 #7218- increase precedence of new meta syntax
6482d41 Fixed duplicate LocalDeclaration annotations introduced in 3af1e3a
7c4279c fix erasure of Boolean
4d0714d fix erasure of Boolean
71d08d5 extract a local
bd03712 #7218 - use new declaration ref syntax in language model doc annotations
1232190 #7218 - simplified metamodel syntax
60327c2 #7218 - change syntax for compiler annotations, to free up @
03a7b4b Improve transpose() documentation
d1bd236 fix #7212 bogus error message
2a1bed4 remove more obsolete methods - code cleanup for java backend
3af1e3a simplify Java backend, using model APIs directly - code cleanup for java backend
d636e01 add missing jar for compiler-js
62bd513 minor cleanups
1fb98d4 minor cleanups
52bf5f7 rescue more changes from 7037 branch. This is not implementation of #7037
dec690c Added a new section for ceylon/ceylon-examples-web to the RELEASE document
b24025c rescue more changes from 7037 branch. This is not implementation of #7037
b091d87 Added missing update instructions for "ceylon-docker/s2i-ceylon"
e2fe3bf rescue more minor changes from the 7037 branch. This is not implementation of #7037
c8f1b3d place tests outside loop - performance improvement in typechecker
e722fb3 rescue a bunch of minor changes from the 7037 branch . This is not implementation of #7037, this provides just util functions and some formating improvements
fcf626b fix #7211 inferred refinements and return
74cc1d1 fix #7211 inferred refinements and return
ba22c6d gitignore bin dir in tools
8fd3031 tests for #7211
b014585 update gitignore for typechecker + test/play
ad3996d transpose() function #7217
644613a one last fix for #6316
41c0f81 Updated SDKMan script
77bdda1 clean up material on conditions and fix #7206
764ef27 roll back d5207f5 and refix #6316
831ead2 Fixed herd build for release
0710157 change spec here, since [Nothing+] is an empty type
546ecb1 fix tests
0843249 fix tests
899872e downgrade error to warning for consistency with exists/nonempty
da18507 remove comma in spec
7fec4c5 spec for #7204
c7eb45c fix whitespaces in spec
5fddd94 unsound 'if(!nonempty [] x = ...)' accepted typechecker #7204
407c6b8 add some tests for nonempty
433bf5c fix spec for nonempty
9b04a11 add warning for 'if (nonempty e = [])' in typechecker
ef80196 renaming methods in typechecker
9bf38d3 improve error message
ec8a1ad improve error message
0d58bc6 Typo/grammar fixes in statements/block chapter (#7202)
616d95a improve doc of Iterable.paired
d5207f5 temporary fix because the fix to #6316
5880feb Fixes of toString() for constructor and function
011da26 cleanup after cleanup :)
a14f348 minor code cleanups
cc55b3e Docs -function → value for formal attributes (typo) (#7200)
ca28ded Docs- fix return type in example (#7199)
8eebe38 optimize more methods of Type for Tuple + fix isReified() #6316
2f77882 optimize Type.equals()/hashCode() for #6316
1f0144d Initial fix for #6316 - stack overflow with very long tuples
0ae476a Cleanup unused import
2989e5f New development phase of 1.3.4, changes in versions
e081da2 NPE fix
@luolong luolong added this to To do in Clean up 1.3.4 Release Feb 7, 2020
@jvasileff
Copy link
Contributor

After a (very) quick review, I concur with the changes up to b24025c. In that range, I didn't notice any compatibility breaks and the only new feature appears to be the relatively harmless addition of transpose()

@Voiteh
Copy link
Contributor Author

Voiteh commented Feb 22, 2020

Could someone check: bd03712, 1232190, 60327c2, c5d2fc7 this is implementation of #7218, although #7218 is not annotated as breaking change I'm not sure if we would have backward compatiblity with that issue onboard

@jvasileff
Copy link
Contributor

jvasileff commented Feb 22, 2020

Incomplete list of commits to (at least partially) revert:

@jvasileff
Copy link
Contributor

jvasileff commented Feb 22, 2020

Regarding the meta model syntax changes #7460 (comment), I suspect that although unwanted, they are fine.

  • I successful compiled and tested everything after reverting bd03712, so the "old" syntax still works for the language module
  • The SDK is still using the old syntax (at least, I didn't notice any commits changing meta refs), and jvm tests are currently passing

Note that there could still be documentation issues or new bugs - I don't know if any website or other doc changes were made, and didn't check to see if there are tests for the new syntax. But given that at least the old syntax seems to work, that's probably good enough for our limited goals.

@Voiteh
Copy link
Contributor Author

Voiteh commented Feb 22, 2020

I'll change commit description as accepted

@Voiteh
Copy link
Contributor Author

Voiteh commented Feb 26, 2020

dfc3bc1, 6798efd, 0222305, 0c7a6e4, 06859f0, 13742e5, db53d11 <---- This guys are for #7220 I dont see any breaking label on the ticket but according to description this will introduce new syntax deprecating old one. Old one will rise warning. I guess wee don't want that for 1.3.4 ??

@jvasileff
Copy link
Contributor

As long as the new let syntax support doesn't break anything, I think we are fine.

Ideally there wouldn't be new features or warnings, but given the difficulty of rolling back commits made before the package renames and IP transfer to Eclipse, rollbacks should be a last resort. And if the future is to use the let keyword, I think we might as well keep the warning on the use of value.

@Voiteh
Copy link
Contributor Author

Voiteh commented Mar 31, 2020

1.3.4 can't happen due to Eclipse package naming requirements

@Voiteh Voiteh closed this as completed Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

2 participants