Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate strict typing in Explorer for Endevor #54

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

katelynienaber
Copy link
Contributor

@katelynienaber katelynienaber commented Nov 2, 2020

Strict typing should be enabled in Explorer for Endevor. So in this PR, the strict option for compilation has been turned on, and all related errors have been fixed.

Changelog: Activated strict typing in the Typescript compiler options

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@katelynienaber
Copy link
Contributor Author

Addresses this issue (but in E4E): zowe/zowe-explorer-vscode#852

@Alexandru-Dumitru
Copy link

Alexandru-Dumitru commented Nov 3, 2020

Please open against development branch. Also please remove the commit message template, as we don't have this set up here.

@katelynienaber katelynienaber changed the base branch from master to development November 3, 2020 12:48
@katelynienaber
Copy link
Contributor Author

Please open against development branch. Also please remove the commit message template, as we don't have this set up here.

Done ^^

Copy link

@Alexandru-Dumitru Alexandru-Dumitru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and runs ok. Thanks for doing it.

Alexandru-Paul Dumitru added 2 commits November 5, 2020 16:15
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
@zdmullen zdmullen merged commit c7fc3fc into eclipse-che4z:development Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants