Adding missing information #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maléř <mmaler@redhat.com>
MichalMaler
requested review from
yhontyk,
l0rd,
rkratky and
themr0c
as code owners
yhontyk
reviewed
Jun 29, 2020
| @@ -15,4 +15,7 @@ The {prod-short} server, also known as *wsmaster*, is the central service of the | |||
|
|
|||
| | Container image | |||
| | `eclipse/che-server` | |||
|
|
|||
| | Environment variables | |||
| | link:https://www.eclipse.org/che/docs/che-7/advanced-configuration-options-for-the-che-server-component/[Advanced configuration options for the Che server component] | |||
There was a problem hiding this comment.
This is not downstream-friendly. Can we use an attribute here?
There was a problem hiding this comment.
From what I know from Serhii Leshchenko, currently on PTO, the Controller is not part of CRW yet, so this is pure upstream ATM. I will add the attribute for this link in the comments, so it could be easily used in the future when a CRW counterpart will exist.
There was a problem hiding this comment.
Even though we have it in the downstream docs already:
https://access.redhat.com/documentation/en-us/red_hat_codeready_workspaces/2.1/html/administration_guide/codeready-workspaces-architectural-elements_crw#codeready-workspaces-workspace-controller_crw
Signed-off-by: Michal Maléř <mmaler@redhat.com>
yhontyk
approved these changes
Jun 29, 2020
Signed-off-by: Michal Maléř <mmaler@redhat.com>
MichalMaler
added a commit
to MichalMaler/che-docs
that referenced
this pull request
Jun 29, 2020
* Adding missing information Signed-off-by: Michal Maléř <mmaler@redhat.com> * reaction to a need for a link attribute Signed-off-by: Michal Maléř <mmaler@redhat.com> * adding a link attribute for a synergy with dowstream Signed-off-by: Michal Maléř <mmaler@redhat.com>
MichalMaler
added a commit
that referenced
this pull request
Jun 29, 2020
* Adding missing information Signed-off-by: Michal Maléř <mmaler@redhat.com> * reaction to a need for a link attribute Signed-off-by: Michal Maléř <mmaler@redhat.com> * adding a link attribute for a synergy with dowstream Signed-off-by: Michal Maléř <mmaler@redhat.com>
|
Merged and Cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Maléř mmaler@redhat.com
Adding info and some missing values for the included tables