-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small modification to the installation proc #1514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhontyk
requested review from
l0rd,
MichalMaler,
rkratky and
themr0c
as code owners
September 1, 2020 10:18
themr0c
reviewed
Sep 1, 2020
...overview/partials/proc_installing-che-using-the-che-operator-in-openshift-4-web-console.adoc
Outdated
Show resolved
Hide resolved
rkratky
reviewed
Sep 1, 2020
...overview/partials/proc_installing-che-using-the-che-operator-in-openshift-4-web-console.adoc
Outdated
Show resolved
Hide resolved
yhontyk
changed the title
[WIP] Small modification to the installation proc
Small modification to the installation proc
Sep 2, 2020
rkratky
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I realized there shouldn't be periods at the end of list items that are not full sentences, such as:
. Enter the project details:
+
* *Name*: `{prod-short}`.
* *Display Name*: `{prod}`.
* *Description*: `{prod}`.
There are more of these in the PR.
...view/partials/assembly_installing-che-using-the-che-operator-in-openshift-4-web-console.adoc
Outdated
Show resolved
Hide resolved
…e-operator-in-openshift-4-web-console.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the installation procedure, breaks one proc into different modules.
What issues does this PR fix or reference?
Specify the version of the product this PR applies to.
PR Checklist
As the author of this Pull Request I made sure that: