Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GDPR] delete all the data related to user account from keycloak #1606

Merged
merged 4 commits into from
Oct 5, 2020

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

Read our Contribution guide before submitting a PR.

What does this PR do?

Explaining how to turn on ability to remove data related to user account from keycloak on deleting user from Che.

What issues does this PR fix or reference?

eclipse-che/che#17541

Specify the version of the product this PR applies to.

7.20

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@themr0c
Copy link
Contributor

themr0c commented Oct 2, 2020

@benoitf is it expected that the vale-pr-check is still not fully functional? The vale errors that are reported here are from the master branch, not from the PR branch.

@themr0c
Copy link
Contributor

themr0c commented Oct 2, 2020

modules/administration-guide/partials/assembly_removing-user-data.adoc
3:2 warning Grade level (13.53) too high! CheDocs.ReadabilityGrade
18:160 suggestion 'are required' is passive IBM.PassiveVoice
voice. Consider rewording in
active voice.
19:27 error Use 'che' instead of 'Che'. Vale.Terms
43:24 suggestion 'are granted' is passive IBM.PassiveVoice
voice. Consider rewording in
active voice.
43:67 suggestion 'is configured' is passive IBM.PassiveVoice
voice. Consider rewording in
active voice.
43:171 suggestion 'are granted' is passive IBM.PassiveVoice
voice. Consider rewording in
active voice.
43:239 warning Consider using 'available' CheDocs.CommonTerms
instead of 'present'
51:30 suggestion 'is logged' is passive voice. IBM.PassiveVoice
Consider rewording in active
voice.
53:13 suggestion 'is obtained' is passive IBM.PassiveVoice
voice. Consider rewording in
active voice.

✖ 1 error, 2 warnings and 6 suggestions in 1 file.

@MichalMaler
Copy link
Contributor

A fork of Che-repo wasnt use here. The branch for this PR is made from the Upstream and pushing against master. I think that's not a good habit. Maybe that's why the checks are running against master?

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@themr0c themr0c merged commit db9c406 into master Oct 5, 2020
@themr0c themr0c deleted the gdpr branch October 5, 2020 08:00
@che-bot che-bot added this to the 7.20 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants